From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v2] fix #4318: ui: qemu/Monitor: rework output retention mechanism
Date: Wed, 16 Nov 2022 20:23:28 +0100 [thread overview]
Message-ID: <fdbdd592-3d6a-ead3-1996-f6caec398041@proxmox.com> (raw)
In-Reply-To: <20221102112837.2450084-1-d.csapak@proxmox.com>
Am 02/11/2022 um 12:28 schrieb Dominik Csapak:
> instead of saving maximum 500 lines, count commands + lines, and only
> if both are over the limit, truncate the command list
>
> this way, at least the last 10 commands + output are always visible, and
> no visible output is truncated, while still not letting the log
> grow infinitely
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * adapted to thomas suggestions
> * var commands => let commands (since i'm touching the line anyway)
> * i adapted the suggest comment from thomas, so it's more clear (imho)
extended that a bit
> www/manager6/qemu/Monitor.js | 29 +++++++++++++++++------------
> 1 file changed, 17 insertions(+), 12 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2022-11-16 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 11:28 [pve-devel] " Dominik Csapak
2022-11-16 19:23 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdbdd592-3d6a-ead3-1996-f6caec398041@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox