From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager] ui: restore: improve warning for restoring container with same ID
Date: Tue, 5 Jul 2022 10:36:27 +0200 [thread overview]
Message-ID: <fdb18fc6-52ee-e3b5-0aef-dcb087206207@proxmox.com> (raw)
In-Reply-To: <20220705080803.26621-1-f.ebner@proxmox.com>
Am 05.07.22 um 10:08 schrieb Fabian Ebner:
> It's not clear to users that the "VM data" includes mount point
> volumes, including those that are not marked for backup. This is
> different from VM restore, where volumes attached at drives not
> present in the backup will be kept around as unused volumes.
>
> Several (supposedly newer) users got tripped up by this over the
> years, the latest report being [0]. The long term plan is to make the
> restore dialog more flexible to be able to select actions for disks
> individually, but that will take a bit of time. In the mean time, make
> the warning more explicit.
>
> [0]: https://forum.proxmox.com/threads/111760/#post-482045
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> www/manager6/window/Restore.js | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js
> index 6738d26f..be2efa3b 100644
> --- a/www/manager6/window/Restore.js
> +++ b/www/manager6/window/Restore.js
> @@ -92,7 +92,13 @@ Ext.define('PVE.window.Restore', {
> };
>
> if (view.vmid) {
> - confirmMsg += '. ' + gettext('This will permanently erase current VM data.');
> + if (view.vmtype === 'lxc') {
> + confirmMsg += `. ${gettext(
> + 'This will permanently erase current CT data including mountpoint volumes.',
> + )}`;
Sorry, forgot that the text needs to be on the very same line for
gettext. Will send a v2 with that reorganized.
> + } else {
> + confirmMsg += `. ${gettext('This will permanently erase current VM data.')}`;
> + }
> Ext.Msg.confirm(gettext('Confirm'), confirmMsg, function(btn) {
> if (btn === 'yes') {
> executeRestore();
prev parent reply other threads:[~2022-07-05 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 8:08 Fabian Ebner
2022-07-05 8:36 ` Fabian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdb18fc6-52ee-e3b5-0aef-dcb087206207@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox