public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH zfsonlinux] cherry-pick lock-inversion patch for zvol_open
Date: Tue, 11 Jan 2022 16:45:44 +0100	[thread overview]
Message-ID: <fda64e5a-263d-a62a-4829-07c39303f272@proxmox.com> (raw)
In-Reply-To: <20220111153936.229984-1-s.ivanov@proxmox.com>

On 11.01.22 16:39, Stoiko Ivanov wrote:
> the changes to zvol_open added to 2.1.2 (for coping with kernel
> changes in 5.13) seem to have introduced a lock order inversion [0].
> 
> (noticed while reviewing the 2.0.6->2.0.7 changes (the patch was
> applied after 2.1.2 was already tagged)
> 
> [0] https://github.com/openzfs/zfs/pull/12863
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> did not reproduce the dead-lock myself (in my very limited tests)
> but given that our 2.1.2 packages (and kernel modules) have not seen
> too much testing in public yet - thought it makes sense to proactively
> pull this in
> 
> quickly tested a kernel+userspace with this patch on a physical testhost
> 
>  .../0012-Fix-zvol_open-lock-inversion.patch   | 212 ++++++++++++++++++
>  debian/patches/series                         |   1 +
>  2 files changed, 213 insertions(+)
>  create mode 100644 debian/patches/0012-Fix-zvol_open-lock-inversion.patch
> 
>

applied, thanks!




      reply	other threads:[~2022-01-11 15:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-11 15:39 [pve-devel] " Stoiko Ivanov
2022-01-11 15:45 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fda64e5a-263d-a62a-4829-07c39303f272@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal