From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH-SERIES ha-manager] avoid rebalance-on-start for newly added already running service
Date: Tue, 6 Jun 2023 19:12:43 +0200 [thread overview]
Message-ID: <fd9d5cfa-892a-b81f-614d-4c76142c5e4a@proxmox.com> (raw)
In-Reply-To: <20230414123830.60720-1-f.ebner@proxmox.com>
Am 14/04/2023 um 14:38 schrieb Fiona Ebner:
> As reported in the community forum[0], the current behavior when
> adding an already running service to HA is wrong. If rebalance
> selected a different node, the service would be stopped, offline
> migrated and started again. Since the rebalance-on-start is only
> intended to trigger on the stopped->start transition[1], this series
> makes sure the service is not migrated at all for rebalance-on-start
> if already running.
>
> [0]: https://forum.proxmox.com/threads/125597/
> [1]: https://pve.proxmox.com/pve-docs/chapter-ha-manager.html#_crs_scheduling_points
>
> Fiona Ebner (4):
> sim: hardware: commands: fix documentation for add
> sim: hardware: commands: make it possible to add already running
> service
> tools: add IGNORED return code
> lrm: do not migrate if service already running upon rebalance on start
>
> src/PVE/HA/LRM.pm | 5 ++
> src/PVE/HA/Manager.pm | 6 ++
> src/PVE/HA/Sim/Hardware.pm | 16 +++--
> src/PVE/HA/Tools.pm | 3 +-
> src/test/test-crs-static-rebalance2/README | 3 +
> src/test/test-crs-static-rebalance2/cmdlist | 9 +++
> .../test-crs-static-rebalance2/datacenter.cfg | 7 +++
> .../hardware_status | 5 ++
> .../test-crs-static-rebalance2/log.expect | 63 +++++++++++++++++++
> .../test-crs-static-rebalance2/manager_status | 1 +
> .../test-crs-static-rebalance2/service_config | 1 +
> .../static_service_stats | 1 +
> 12 files changed, 115 insertions(+), 5 deletions(-)
> create mode 100644 src/test/test-crs-static-rebalance2/README
> create mode 100644 src/test/test-crs-static-rebalance2/cmdlist
> create mode 100644 src/test/test-crs-static-rebalance2/datacenter.cfg
> create mode 100644 src/test/test-crs-static-rebalance2/hardware_status
> create mode 100644 src/test/test-crs-static-rebalance2/log.expect
> create mode 100644 src/test/test-crs-static-rebalance2/manager_status
> create mode 100644 src/test/test-crs-static-rebalance2/service_config
> create mode 100644 src/test/test-crs-static-rebalance2/static_service_stats
>
applied series, thanks!
But, I split the last commit into two, first one adding the (still broken) test,
then in the second the fix with the change to log.expect from broken -> fixed
encoded also in git. IME, this makes such changes a bit easier to understand and
evaluate when checking out the git log in the future.
prev parent reply other threads:[~2023-06-06 17:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 12:38 [pve-devel] " Fiona Ebner
2023-04-14 12:38 ` [pve-devel] [PATCH ha-manager 1/4] sim: hardware: commands: fix documentation for add Fiona Ebner
2023-04-14 12:38 ` [pve-devel] [PATCH ha-manager 2/4] sim: hardware: commands: make it possible to add already running service Fiona Ebner
2023-04-14 12:38 ` [pve-devel] [PATCH ha-manager 3/4] tools: add IGNORED return code Fiona Ebner
2023-04-14 12:38 ` [pve-devel] [PATCH ha-manager 4/4] lrm: do not migrate if service already running upon rebalance on start Fiona Ebner
2023-06-06 17:12 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd9d5cfa-892a-b81f-614d-4c76142c5e4a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox