Re: [PATCH pve-guest-common v2 1/8] AbstractConfig: fix pending delete for options with value 0

[David Riley <d.riley@proxmox.com>]

Consider this:
Reviewed-by: David Riley <d.riley@proxmox.com>

On 10/22/26 2:51 PM, Jakob Klocker wrote:
> When building the merged runtime configuration (`load_current_config`),
> pending deletions check `if $conf->{$opt}` before clearing keys. Because
> a value of `0` evaluates to false in Perl, the condition fails and the
> key is left in the merged view.
>
> While the final configuration application on restart still clears the
> key, this causes UI desynchronization during the pending state (e.g., UI
> components see the old `0` value and misrender). Using `defined` ensures
> the merged view correctly reflects pending deletions immediately.
>
> Signed-off-by: Jakob Klocker<j.klocker@proxmox.com>
> ---
>   src/PVE/AbstractConfig.pm | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/AbstractConfig.pm b/src/PVE/AbstractConfig.pm
> index 7bcae19..a708ced 100644
> --- a/src/PVE/AbstractConfig.pm
> +++ b/src/PVE/AbstractConfig.pm
> @@ -242,7 +242,7 @@ sub load_current_config {
>           }
>           my $pending_delete_hash = $class->parse_pending_delete($conf->{pending}->{delete});
>           foreach my $opt (keys %$pending_delete_hash) {
> -            delete $conf->{$opt} if $conf->{$opt};
> +            delete $conf->{$opt} if defined $conf->{$opt};
>           }
>       }
>