From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v4 manager 2/3] ui: backup: fill in some of the configured vzdump defaults
Date: Mon, 3 May 2021 15:02:16 +0200 [thread overview]
Message-ID: <fcd1f529-472a-d55c-23a2-e7c74712404a@proxmox.com> (raw)
In-Reply-To: <20210406104152.11014-2-f.ebner@proxmox.com>
On 06.04.21 12:41, Fabian Ebner wrote:
> Do not fill in the default for compression, because the initial default for the
> backend is to not compress, while the current default for the UI is zstd, which
> is preferable.
>
> The 'defaults' API call expects the user to have permissions on the storage,
> because retention options are storage-dependent. Use a flag initialDefaults to
> make sure storage-independent properties are only set once, so they are not
> reset when a user changes the storage after editing them.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> No changes from v3.
>
> www/manager6/window/Backup.js | 52 +++++++++++++++++++++++++++--------
> 1 file changed, 40 insertions(+), 12 deletions(-)
>
>
applied, thanks!
next prev parent reply other threads:[~2021-05-03 13:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 10:41 [pve-devel] [PATCH v4 manager 1/3] api: vzdump: add call to get currently " Fabian Ebner
2021-04-06 10:41 ` [pve-devel] [PATCH v4 manager 2/3] ui: backup: fill in some of the " Fabian Ebner
2021-05-03 13:02 ` Thomas Lamprecht [this message]
2021-04-06 10:41 ` [pve-devel] [PATCH v4 manager 3/3] fix #2745: ui: backup: allow specifying remove parameter for manual backup Fabian Ebner
2021-05-03 13:02 ` [pve-devel] applied: [PATCH v4 manager 1/3] api: vzdump: add call to get currently configured vzdump defaults Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcd1f529-472a-d55c-23a2-e7c74712404a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox