From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dietmar Maurer <dietmar@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-access-control v2 0/5] add OpenId realms
Date: Thu, 1 Jul 2021 13:38:58 +0200 [thread overview]
Message-ID: <fccfb439-37a8-4f82-2a11-6c763b38a5e6@proxmox.com> (raw)
In-Reply-To: <20210630061007.3345396-1-dietmar@proxmox.com>
On 30.06.21 08:10, Dietmar Maurer wrote:
> Changes in v2:
> - also check if user is expired (in check_user_enabled)
> - always die with newline
> - rename "user-attr" to "username-claim"
>
>
> Dietmar Maurer (5):
> check_user_enabled: also check if user is expired
> add OpenId configuration
> depend on libpve-rs-perl
> api: implement openid API
> implement OpenID autocreate user feature
>
> debian/control | 2 +
> src/PVE/API2/AccessControl.pm | 60 ++-------
> src/PVE/API2/Makefile | 3 +-
> src/PVE/API2/OpenId.pm | 238 ++++++++++++++++++++++++++++++++++
> src/PVE/AccessControl.pm | 18 +--
> src/PVE/Auth/Makefile | 3 +-
> src/PVE/Auth/OpenId.pm | 68 ++++++++++
> src/PVE/RPCEnvironment.pm | 49 +++++++
> 8 files changed, 378 insertions(+), 63 deletions(-)
> create mode 100644 src/PVE/API2/OpenId.pm
> create mode 100755 src/PVE/Auth/OpenId.pm
>
applied series, thanks!
But I moved the second hunk:
- if (defined(my $user_attr = $config->{'user-attr'})) {
+ if (defined(my $user_attr = $config->{'username-claim'})) {
of patch 5/5 ("implement OpenID autocreate user feature") into the previous
patch 4/5 ("api: implement openid API") and adapted the error message in
that if/else chain, as it still talked about "user_attrs" from v1.
prev parent reply other threads:[~2021-07-01 11:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 6:10 [pve-devel] " Dietmar Maurer
2021-06-30 6:10 ` [pve-devel] [PATCH pve-access-control v2 1/5] check_user_enabled: also check if user is expired Dietmar Maurer
2021-06-30 7:28 ` Fabian Grünbichler
2021-06-30 6:10 ` [pve-devel] [PATCH pve-access-control v2 2/5] add OpenId configuration Dietmar Maurer
2021-06-30 6:10 ` [pve-devel] [PATCH pve-access-control v2 3/5] depend on libpve-rs-perl Dietmar Maurer
2021-06-30 6:10 ` [pve-devel] [PATCH pve-access-control v2 4/5] api: implement openid API Dietmar Maurer
2021-06-30 6:10 ` [pve-devel] [PATCH pve-access-control v2 5/5] implement OpenID autocreate user feature Dietmar Maurer
2021-07-01 11:38 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fccfb439-37a8-4f82-2a11-6c763b38a5e6@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox