Re: [PATCH proxmox-ve-rs 3/9] frr: allow rendering prefix-lists/route-maps separately

[Stefan Hanreich <s.hanreich@proxmox.com>]

On 3/27/26 11:50 AM, Hannes Laimer wrote:
> On 2026-03-25 10:43, Stefan Hanreich wrote:
>> This is mainly useful for integration tests for the route maps /
>> prefix lists feature in ve-config. It utilizes those methods to render
>> route maps and prefix lists in tests, without having to render a full
>> FRR configuration.
>>
>> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
>> ---
>>  proxmox-frr/src/ser/serializer.rs | 35 ++++++++++++++++++++++++++++++-
>>  1 file changed, 34 insertions(+), 1 deletion(-)
>>
>> diff --git a/proxmox-frr/src/ser/serializer.rs b/proxmox-frr/src/ser/serializer.rs
>> index 2ac85d8..91aff1f 100644
>> --- a/proxmox-frr/src/ser/serializer.rs
>> +++ b/proxmox-frr/src/ser/serializer.rs
>> @@ -1,7 +1,12 @@
>> +use std::collections::BTreeMap;
>> +
>>  use anyhow::Context;
>>  use minijinja::Environment;
>>  
>> -use crate::ser::FrrConfig;
>> +use crate::ser::{
>> +    route_map::{PrefixListName, PrefixListRule, RouteMapEntry, RouteMapName},
>> +    FrrConfig,
>> +};
>>  use proxmox_sortable_macro::sortable;
>>  
>>  #[sortable]
>> @@ -91,3 +96,31 @@ pub fn dump(config: &FrrConfig) -> Result<String, anyhow::Error> {
>>  pub fn to_raw_config(config: &FrrConfig) -> Result<Vec<String>, anyhow::Error> {
>>      Ok(dump(config)?.lines().map(|line| line.to_owned()).collect())
>>  }
>> +
>> +/// Render Prefix Lists into an FRR config string.
>> +///
>> +/// Currently only used for testing the rendering of prefix lists, to avoid having to render the
>> +/// whole FRR configuration file.
>> +pub fn render_prefix_lists(
>> +    prefix_lists: BTreeMap<PrefixListName, Vec<PrefixListRule>>,
>> +) -> Result<String, anyhow::Error> {
>> +    create_env()
>> +        .get_template("prefix_lists.jinja")
>> +        .with_context(|| "could not obtain frr template from environment")?
>> +        .render(prefix_lists)
> 
> the templates expect named keys, no?
> ```
> -        .render(prefix_lists)
> +        .render(minijinja::context! { prefix_lists => prefix_lists })
> ```
> 

they're actually unused and just leftover from development - will be
removed in the upcoming v2, since the tests switched over to using dump
anyway...