From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH manager v3] api: ceph: improve reporting of ceph OSD memory usage
Date: Mon, 4 Sep 2023 15:47:35 +0200 [thread overview]
Message-ID: <fc2cb0ad-7d77-4a4b-5393-673fa751310e@proxmox.com> (raw)
In-Reply-To: <14129d30-0d14-4700-aa49-0afd2607f236@proxmox.com>
On 9/4/23 15:14, Thomas Lamprecht wrote:
> Am 04/09/2023 um 11:18 schrieb Stefan Hanreich:
>> ---
>> Changes from v2:
>> * closing the file handle after using it
>> * improved error message when failing to open proc file
>> * add hint in the UI that we are using PSS
>> * mentioned Aaron's involvement in commit message
>
> missing factoring this out to own helper to avoid crowding the API endpoint
> code itself to much, like asked in my review.. If you don't agree please
> state that at least, ideally with a reason..
>
Sorry, I misunderstood the answer as don't factor it out at all for now
- but I see now that this was specifically related to ProcFSTools...
prev parent reply other threads:[~2023-09-04 13:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 9:18 [pve-devel] " Stefan Hanreich
2023-09-04 13:14 ` [pve-devel] applied: " Thomas Lamprecht
2023-09-04 13:47 ` Stefan Hanreich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc2cb0ad-7d77-4a4b-5393-673fa751310e@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox