Re: [pve-devel] [PATCH manager v2 1/2] ui: tasks: add actioncolumn to open task

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 11.11.24 um 16:50 schrieb Aaron Lauterer:
> Many (new) users don't realize that the task view can be used to open
> the task details.
> By adding a small action column we can have a button to open the task as
> well, next to double clicking it.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> Since the record is fetched quite differently than in the regular
> handler, and we don't necessarily have a selection on the right row at
> this point, I opted to create the window right in the dedicated handler.
> 
> The other sensible approach would be to factor out the window opening
> from `run_task_viewer` into a new function. But since that function
> would just open the window I decided against it.
> 
> Not sure if we want the above explanation in the commit msg. If so, feel
> free to put it there when applying the patch.
> 
> Regarding the icon: I went with the chevron-right as this is what we use
> in the UI of the backup server. Alternatively the `fa-eye` might also be
> fitting.

Looks fine code-wise, but we got some inconsistency with these things:

- PBS uses the same icon but uses "Open Task" as tooltip
- our dedicated Task panel, used for the per-node or per-guest task logs
  is using "View" as button text with fa-window-restore as icon.
  Also, it would be good to think over if it makes sense adding the action
  column there too, albeit I'm not having problems with skipping that for
  now

fa-eye is IMO worse on its own and, more objectively, as that it further
increases the grade of inconsistency.




_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel