From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hrdlicka <s.hrdlicka@proxmox.com>
Subject: [pve-devel] applied: [PATCH V4 manager 2/3] fix #3967: enable ZFS dRAID creation in WebGUI
Date: Thu, 17 Nov 2022 19:34:57 +0100 [thread overview]
Message-ID: <fbda7d0d-275e-e2f9-f548-622b7b0a9987@proxmox.com> (raw)
In-Reply-To: <20221110132450.567121-3-s.hrdlicka@proxmox.com>
Am 10/11/2022 um 14:24 schrieb Stefan Hrdlicka:
> add fields for additional settings required by ZFS dRAID
>
> Signed-off-by: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
> ---
> www/manager6/node/ZFS.js | 69 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 69 insertions(+)
>
>
applied, thanks! Note that I reworked both the layout and the config handling a bit.
Basically we can avoid quite some view-model binding/formula stuff and the extra
field just by using the onGetValues submit hook that our InputPanel provides.
Moving the fields then below just makes the form a bit more balanced, no biggie
there.
next prev parent reply other threads:[~2022-11-17 18:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 13:24 [pve-devel] [PATCH V4 SERIES storage/manager/docs 0/3] fix #3967: add ZFS dRAID creation Stefan Hrdlicka
2022-11-10 13:24 ` [pve-devel] [PATCH V4 storage 1/3] fix #3967: enable ZFS dRAID creation via API Stefan Hrdlicka
2022-11-11 8:40 ` [pve-devel] applied: " Thomas Lamprecht
2022-11-10 13:24 ` [pve-devel] [PATCH V4 manager 2/3] fix #3967: enable ZFS dRAID creation in WebGUI Stefan Hrdlicka
2022-11-17 18:34 ` Thomas Lamprecht [this message]
2022-11-10 13:24 ` [pve-devel] [PATCH V4 docs 3/3] fix #3967: add ZFS dRAID documentation Stefan Hrdlicka
2022-11-17 18:35 ` [pve-devel] applied: " Thomas Lamprecht
2022-11-10 13:43 ` [pve-devel] [PATCH V4 SERIES storage/manager/docs 0/3] fix #3967: add ZFS dRAID creation Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbda7d0d-275e-e2f9-f548-622b7b0a9987@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hrdlicka@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox