* [pve-devel] [PATCH pve-manager] d/control: change binary package architecture from `any` to `all`
@ 2024-09-12 14:25 Jing Luo via pve-devel
2024-09-13 10:09 ` Fabian Grünbichler
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jing Luo via pve-devel @ 2024-09-12 14:25 UTC (permalink / raw)
To: pve-devel; +Cc: Jing Luo
[-- Attachment #1: Type: message/rfc822, Size: 5824 bytes --]
From: Jing Luo <jing@jing.rocks>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>
Subject: [PATCH pve-manager] d/control: change binary package architecture from `any` to `all`
Date: Thu, 12 Sep 2024 23:25:49 +0900
Message-ID: <20240912142753.1280695-1-jing@jing.rocks>
There is no architecture dependent binary files in the final deb
package. There is no shared libs either (says debhelper), so let's remove
that too.
Signed-off-by: Jing Luo <jing@jing.rocks>
---
debian/control | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/debian/control b/debian/control
index d844cc15..a3cb632f 100644
--- a/debian/control
+++ b/debian/control
@@ -34,7 +34,7 @@ Maintainer: Proxmox Support Team <support@proxmox.com>
Package: pve-manager
Section: admin
Priority: optional
-Architecture: any
+Architecture: all
Depends: apt (>= 1.5~),
ca-certificates,
cstream,
@@ -97,7 +97,6 @@ Depends: apt (>= 1.5~),
zstd,
${misc:Depends},
${perl:Depends},
- ${shlibs:Depends},
Recommends: libpve-network-perl (>= 0.9~),
proxmox-firewall,
proxmox-offline-mirror-helper,
--
2.46.0
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [pve-devel] [PATCH pve-manager] d/control: change binary package architecture from `any` to `all`
2024-09-12 14:25 [pve-devel] [PATCH pve-manager] d/control: change binary package architecture from `any` to `all` Jing Luo via pve-devel
@ 2024-09-13 10:09 ` Fabian Grünbichler
2024-09-13 10:55 ` [pve-devel] [PATCH pve-manager v2] " Jing Luo via pve-devel
[not found] ` <20240913110157.1454303-2-jing@jing.rocks>
2 siblings, 0 replies; 5+ messages in thread
From: Fabian Grünbichler @ 2024-09-13 10:09 UTC (permalink / raw)
To: Proxmox VE development discussion; +Cc: Jing Luo
> Jing Luo via pve-devel <pve-devel@lists.proxmox.com> hat am 12.09.2024 16:25 CEST geschrieben:
> There is no architecture dependent binary files in the final deb
> package. There is no shared libs either (says debhelper), so let's remove
> that too.
>
> Signed-off-by: Jing Luo <jing@jing.rocks>
Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
not applying directly in case I missed some spot where this is hard-coded that requires adaptations, but it seems sound to me.
> ---
> debian/control | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/debian/control b/debian/control
> index d844cc15..a3cb632f 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -34,7 +34,7 @@ Maintainer: Proxmox Support Team <support@proxmox.com>
> Package: pve-manager
> Section: admin
> Priority: optional
> -Architecture: any
> +Architecture: all
> Depends: apt (>= 1.5~),
> ca-certificates,
> cstream,
> @@ -97,7 +97,6 @@ Depends: apt (>= 1.5~),
> zstd,
> ${misc:Depends},
> ${perl:Depends},
> - ${shlibs:Depends},
> Recommends: libpve-network-perl (>= 0.9~),
> proxmox-firewall,
> proxmox-offline-mirror-helper,
> --
> 2.46.0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* [pve-devel] [PATCH pve-manager v2] d/control: change binary package architecture from `any` to `all`
2024-09-12 14:25 [pve-devel] [PATCH pve-manager] d/control: change binary package architecture from `any` to `all` Jing Luo via pve-devel
2024-09-13 10:09 ` Fabian Grünbichler
@ 2024-09-13 10:55 ` Jing Luo via pve-devel
2024-11-11 22:35 ` [pve-devel] applied: " Thomas Lamprecht
[not found] ` <20240913110157.1454303-2-jing@jing.rocks>
2 siblings, 1 reply; 5+ messages in thread
From: Jing Luo via pve-devel @ 2024-09-13 10:55 UTC (permalink / raw)
To: pve-devel; +Cc: Jing Luo
[-- Attachment #1: Type: message/rfc822, Size: 6939 bytes --]
From: Jing Luo <jing@jing.rocks>
To: pve-devel@lists.proxmox.com
Cc: "Jing Luo" <jing@jing.rocks>, "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [PATCH pve-manager v2] d/control: change binary package architecture from `any` to `all`
Date: Fri, 13 Sep 2024 19:55:54 +0900
Message-ID: <20240913110157.1454303-2-jing@jing.rocks>
There is no architecture dependent binary files in the final deb
package. There is no shared libs either (says debhelper), so let's remove
that too.
Signed-off-by: Jing Luo <jing@jing.rocks>
Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
Changes since v1:
Change the $(DEB) in Makefile too, forgot to add it in v1 somehow.
https://lists.proxmox.com/pipermail/pve-devel/2024-September/065362.html
---
Makefile | 2 +-
debian/control | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index 337682b3..fbd75f51 100644
--- a/Makefile
+++ b/Makefile
@@ -7,7 +7,7 @@ export VERSION = $(DEB_VERSION_UPSTREAM_REVISION)
BUILDDIR = $(PACKAGE)-$(DEB_VERSION_UPSTREAM)
DSC=$(PACKAGE)_$(DEB_VERSION).dsc
-DEB=$(PACKAGE)_$(DEB_VERSION)_$(DEB_HOST_ARCH).deb
+DEB=$(PACKAGE)_$(DEB_VERSION)_all.deb
DESTDIR=
SUBDIRS = aplinfo PVE bin www services configs network-hooks test templates
diff --git a/debian/control b/debian/control
index d844cc15..a3cb632f 100644
--- a/debian/control
+++ b/debian/control
@@ -34,7 +34,7 @@ Maintainer: Proxmox Support Team <support@proxmox.com>
Package: pve-manager
Section: admin
Priority: optional
-Architecture: any
+Architecture: all
Depends: apt (>= 1.5~),
ca-certificates,
cstream,
@@ -97,7 +97,6 @@ Depends: apt (>= 1.5~),
zstd,
${misc:Depends},
${perl:Depends},
- ${shlibs:Depends},
Recommends: libpve-network-perl (>= 0.9~),
proxmox-firewall,
proxmox-offline-mirror-helper,
--
2.46.0
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 5+ messages in thread[parent not found: <20240913110157.1454303-2-jing@jing.rocks>]
* [pve-devel] Fwd: [RESEND PATCH pve-manager v2] d/control: change binary package architecture from `any` to `all`
[not found] ` <20240913110157.1454303-2-jing@jing.rocks>
@ 2024-09-23 3:29 ` Jing Luo via pve-devel
0 siblings, 0 replies; 5+ messages in thread
From: Jing Luo via pve-devel @ 2024-09-23 3:29 UTC (permalink / raw)
To: pve-devel; +Cc: Jing Luo
[-- Attachment #1: Type: message/rfc822, Size: 6985 bytes --]
From: Jing Luo <jing@jing.rocks>
To: pve-devel@lists.proxmox.com
Subject: Fwd: [RESEND PATCH pve-manager v2] d/control: change binary package architecture from `any` to `all`
Date: Mon, 23 Sep 2024 12:29:08 +0900
Message-ID: <dfa2a29663df56db02d24ed35f55fdb8@jing.rocks>
Resend, without a link to the mailing list archive
-------- Original Message --------
Subject: [PATCH pve-manager v2] d/control: change binary package
architecture from `any` to `all`
Date: 2024-09-13 19:55
From: Jing Luo <jing@jing.rocks>
To: pve-devel@lists.proxmox.com
Cc: Jing Luo <jing@jing.rocks>, Fabian Grünbichler
<f.gruenbichler@proxmox.com>
There is no architecture dependent binary files in the final deb
package. There is no shared libs either (says debhelper), so let's
remove
that too.
Signed-off-by: Jing Luo <jing@jing.rocks>
Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
Changes since v1:
Change the $(DEB) in Makefile too, forgot to add it in v1 somehow.
---
Makefile | 2 +-
debian/control | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index 337682b3..fbd75f51 100644
--- a/Makefile
+++ b/Makefile
@@ -7,7 +7,7 @@ export VERSION = $(DEB_VERSION_UPSTREAM_REVISION)
BUILDDIR = $(PACKAGE)-$(DEB_VERSION_UPSTREAM)
DSC=$(PACKAGE)_$(DEB_VERSION).dsc
-DEB=$(PACKAGE)_$(DEB_VERSION)_$(DEB_HOST_ARCH).deb
+DEB=$(PACKAGE)_$(DEB_VERSION)_all.deb
DESTDIR=
SUBDIRS = aplinfo PVE bin www services configs network-hooks test
templates
diff --git a/debian/control b/debian/control
index d844cc15..a3cb632f 100644
--- a/debian/control
+++ b/debian/control
@@ -34,7 +34,7 @@ Maintainer: Proxmox Support Team <support@proxmox.com>
Package: pve-manager
Section: admin
Priority: optional
-Architecture: any
+Architecture: all
Depends: apt (>= 1.5~),
ca-certificates,
cstream,
@@ -97,7 +97,6 @@ Depends: apt (>= 1.5~),
zstd,
${misc:Depends},
${perl:Depends},
- ${shlibs:Depends},
Recommends: libpve-network-perl (>= 0.9~),
proxmox-firewall,
proxmox-offline-mirror-helper,
--
2.46.0
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-11-11 22:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-12 14:25 [pve-devel] [PATCH pve-manager] d/control: change binary package architecture from `any` to `all` Jing Luo via pve-devel
2024-09-13 10:09 ` Fabian Grünbichler
2024-09-13 10:55 ` [pve-devel] [PATCH pve-manager v2] " Jing Luo via pve-devel
2024-11-11 22:35 ` [pve-devel] applied: " Thomas Lamprecht
[not found] ` <20240913110157.1454303-2-jing@jing.rocks>
2024-09-23 3:29 ` [pve-devel] Fwd: [RESEND PATCH " Jing Luo via pve-devel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox