[pve-devel] applied: [PATCH v2 firewall] introduce new icmp-type parameter

[pve-devel] applied: [PATCH v2 firewall] introduce new icmp-type parameter

[Thomas Lamprecht]

On 29.05.20 14:22, Mira Limbeck wrote:
> Currently icmp types are handled via 'dport'. This is not documented
> anywhere except for a single line of comment in the code. To untangle
> the icmp-type handling from the dport handling a new 'icmp-type'
> parameter is introduced.
> 
> The valid 'icmp-type' values are limited to the names
> (icmp[v6]_type_names hash in the code, same as ip[6]tables provides).
> Type[/Code] values are not supported.
> 
> Support for ipv6-icmp is added to icmp-type parameter handling. This makes it
> possible to specify icmpv6 types via the GUI.
> 
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> ---
> v2:
>  - rebased on master
>  - removed type[/code] value support, now only names are accepted
> 
>  src/PVE/API2/Firewall/Rules.pm |  4 +++
>  src/PVE/Firewall.pm            | 50 +++++++++++++++++++++++++++++++++-
>  2 files changed, 53 insertions(+), 1 deletion(-)
> 
>

applied, thanks!

[pve-devel] applied: [PATCH v2 docs] add documentation for the new icmp-type parameter

[Thomas Lamprecht]

On 29.05.20 14:22, Mira Limbeck wrote:
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> ---
> v2:
>  - rebased on master
> 
>  pve-firewall-rules-opts.adoc | 4 ++++
>  1 file changed, 4 insertions(+)
> 
>

applied, thanks!

[pve-devel] applied: [PATCH manager v2] change icmp type selector to a combogrid

[Thomas Lamprecht]

On 29.05.20 14:22, Mira Limbeck wrote:
> The combogrid contains all valid icmp types that iptables accepts. In
> addition to the names, the Type[/Code] value is shown as well. But
> specifying Type[/Code] is not supported.
> 
> As the simple solution with setStore() does not work to change the store
> for the combogrid, we simply have 2 different ICMPTypeSelectors, one for
> IPv4, the other for IPv6, which are switched depending on the specified
> protocol.
> 
> As disabled fields don't submit their value, we can keep the values for
> the dport and both icmp-type fields when switching protocols.
> 
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> ---
> v2:
>  - rebased on master
>  - removed unnecessary name switching and removing of values on proto
>    switch
> 
>  www/manager6/grid/FirewallRules.js | 164 ++++++++++++++++++++++++++++-
>  1 file changed, 160 insertions(+), 4 deletions(-)
> 
>

applied, thanks!