public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Friedrich Weber <f.weber@proxmox.com>
Subject: [pve-devel] applied: [PATCH docs v2] fix #5429: network: override device names: include Type=ether
Date: Mon, 29 Apr 2024 15:44:24 +0200	[thread overview]
Message-ID: <fb75c403-6926-4c3d-aa63-27923abbb490@proxmox.com> (raw)
In-Reply-To: <20240429074922.57340-1-f.weber@proxmox.com>

Am 29/04/2024 um 09:49 schrieb Friedrich Weber:
> Mention that the systemd link file should contain `Type=ether` in most
> setup, to make sure it only applies to Ethernet devices and does not
> ever apply to e.g. bridges or bonds which inherit the MAC address of
> the Ethernet device. Mention that some setups may require other
> options.
> 
> Reported in the forum [0] and in #5429 [1].
> 
> [0] https://forum.proxmox.com/threads/144557/post-656188
> [1] https://bugzilla.proxmox.com/show_bug.cgi?id=5429
> 
> Fixes: 96c0261 ("fix #4847: network: extend section on interface naming scheme")
> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
> ---
> 
> Notes:
>     Changes v1 -> v2:
>     
>     - link #5429 which was opened in the meantime
>     - expand on why Type=ether is recommended
>     - mention that some setups may require other choices (thx Thomas)
>     
>     v1: https://lists.proxmox.com/pipermail/pve-devel/2024-April/063659.html
> 
>  pve-network.adoc | 19 ++++++++++++++-----
>  1 file changed, 14 insertions(+), 5 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2024-04-29 13:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-29  7:49 [pve-devel] " Friedrich Weber
2024-04-29 13:44 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb75c403-6926-4c3d-aa63-27923abbb490@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.weber@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal