Re: [pve-devel] [PATCH manager v7 0/3] allow importing vm disk images on the UI

["Michael Köppl" <m.koeppl@proxmox.com>]

On 4/8/25 14:13, Dominik Csapak wrote:
> this is a continuation of my previous series [0]
> 
> It enables importing disks on the UI in the HardwareView of a vm,
> in the create wizard, and in the storage content view.
> 
> I split the patches so that the wizard and storage content view one are
> separate, so they can be reviewed independently.
> 
> changes from v6:
> * drop applied patches
> * make import in hd edit panel dependant on configuration, instead of
>    showing a checkbox
> * wizard and HardwareView got an explicit import button
> * make the import button work on the storage content view for disk
>    images
> * split patches for hdedit, wizard and storage content
> 
> 0: https://lore.proxmox.com/pve-devel/20250407101310.3196974-1-d.csapak@proxmox.com/

Hi,

tested this by creating disk images from existing VMs and importing them 
in the following ways:
- during creation of a VM in the CreateWizard
- through the Hardware view of an existing VM, then changing the boot 
order to boot from the imported disk
- from the storage content view; uploaded a disk image and imported into 
an existing VM from there
- imported with IDE, SATA, SCSI, and VirtIO controllers
- imported qcow2, vmdk, and raw disk images

The tested cases worked as I would expect and I was able to create and 
start VMs with the given images. Creating multiple new VMs with imported 
disks in parallel did slow down the creation considerably, but otherwise 
worked without problems for me. I also tried adding, removing, changing 
disks in the CreateWizard to see if I could get around the constraints 
set for the new selectors. The UI part was overall intuitive to use.

I pondered a bit on the icon chosen for the import, but would could not 
really find a more fitting one. Maybe someone else has a stronger 
opinion on this?

So please consider this:

Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
Tested-by: Michael Köppl <m.koeppl@proxmox.com>



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel