[pve-devel] [PATCH widget-toolkit] node: repos: Use won't rather than don't

[pve-devel] [PATCH widget-toolkit] node: repos: Use won't rather than don't

[Maximiliano Sandoval]

It would be preferable to use "won't" but I would rather err on the safe
side when it comes to escapes in gettext.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 src/node/APTRepositories.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
index 4e74da2..f27e713 100644
--- a/src/node/APTRepositories.js
+++ b/src/node/APTRepositories.js
@@ -471,7 +471,7 @@ Ext.define('Proxmox.node.APTRepositories', {
 
 	    if (!enterprise && !nosubscription && !test) {
 		addCritical(
-		    Ext.String.format(gettext('No {0} repository is enabled, you do not get any updates!'), vm.get('product')),
+		    Ext.String.format(gettext('No {0} repository is enabled, you would not get any updates!'), vm.get('product')),
 		);
 	    } else if (errors.length > 0) {
 		// nothing extra, just avoid that we show "get updates"
-- 
2.39.2

Re: [pve-devel] [PATCH widget-toolkit] node: repos: Use won't rather than don't

[Dietmar Maurer]

Do you also plan to fix those typos in the translation files?
Else we need to re-tralstale them for all languages!

> On 24.11.2023 15:58 CET Maximiliano Sandoval <m.sandoval@proxmox.com> wrote:
> 
>  
> It would be preferable to use "won't" but I would rather err on the safe
> side when it comes to escapes in gettext.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  src/node/APTRepositories.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
> index 4e74da2..f27e713 100644
> --- a/src/node/APTRepositories.js
> +++ b/src/node/APTRepositories.js
> @@ -471,7 +471,7 @@ Ext.define('Proxmox.node.APTRepositories', {
>  
>  	    if (!enterprise && !nosubscription && !test) {
>  		addCritical(
> -		    Ext.String.format(gettext('No {0} repository is enabled, you do not get any updates!'), vm.get('product')),
> +		    Ext.String.format(gettext('No {0} repository is enabled, you would not get any updates!'), vm.get('product')),
>  		);
>  	    } else if (errors.length > 0) {
>  		// nothing extra, just avoid that we show "get updates"
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH widget-toolkit] node: repos: Use won't rather than don't

[Lukas Wagner]

On 11/24/23 15:58, Maximiliano Sandoval wrote:
> -		    Ext.String.format(gettext('No {0} repository is enabled, you do not get any updates!'), vm.get('product')),
> +		    Ext.String.format(gettext('No {0} repository is enabled, you would not get any updates!'), vm.get('product')),

The long form of won't is 'will not', not 'would not'. 'will not' also 
seems more appropriate here.

-- 
- Lukas

Re: [pve-devel] [PATCH widget-toolkit] node: repos: Use won't rather than don't

[Fiona Ebner]

Am 24.11.23 um 16:41 schrieb Lukas Wagner:
> 
> 
> On 11/24/23 15:58, Maximiliano Sandoval wrote:
>> -            Ext.String.format(gettext('No {0} repository is enabled,
>> you do not get any updates!'), vm.get('product')),
>> +            Ext.String.format(gettext('No {0} repository is enabled,
>> you would not get any updates!'), vm.get('product')),
> 
> The long form of won't is 'will not', not 'would not'. 'will not' also
> seems more appropriate here.
> 

Both wordings are correct, just a different tense

You do not get any updates (i.e. right now)
You will not get any updates (i.e. in the future)

Is there a good reason for changing it in the first place? Should be
mentioned in the commit message then ;)