Re: [PATCH proxmox_dart_api_client 2/2] deps: add objective_c dependency to access NSError's code property

[Dominik Csapak <d.csapak@proxmox.com>]

the actual changes look ok, but you mixed in whitespace changes, which
makes it harder to see what was actually the intended patch

please send whitespace changes as a separate patch

On 4/10/26 5:09 PM, Shan Shaji wrote:
> Starting from `v9.0.0` of the `objective_c` package, `NSError` is defined
> as an extension type [0] instead of a wrapper class in Dart. As a result, the
> `code` property is not accessible at compile time unless the extension
> type is explicitly imported, even though the underlying object exposes
> it at runtime.
> 
> To fix this, the `objective_c` dependency has been added and imported the
> dependency were the code property is accessed.
> 
> - [0] https://github.com/dart-lang/native/pull/2723
> 
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>   lib/src/authenticate.dart | 15 ++++++---------
>   pubspec.lock              |  2 +-
>   pubspec.yaml              |  1 +
>   3 files changed, 8 insertions(+), 10 deletions(-)
> 
> diff --git a/lib/src/authenticate.dart b/lib/src/authenticate.dart
> index 4c9ae22..203c165 100644
> --- a/lib/src/authenticate.dart
> +++ b/lib/src/authenticate.dart
> @@ -7,6 +7,7 @@ import 'package:http/http.dart' as http;
>   import 'package:proxmox_dart_api_client/proxmox_dart_api_client.dart';
>   import 'package:proxmox_dart_api_client/src/handle_ticket_response.dart';
>   import 'package:proxmox_dart_api_client/src/models/serializers.dart';
> +import 'package:objective_c/objective_c.dart';
>   
>   /// Returns an authenticated client to work with if successful.
>   ///
> @@ -38,10 +39,7 @@ Future<ProxmoxApiClient> authenticate(
>         print("retrying for backward compat!");
>         final errors = jsonDecode(response.body)['errors'] ?? {};
>         if (errors.containsKey('new-format')) {
> -        var body = {
> -          'username': username,
> -          'password': password,
> -        };
> +        var body = {'username': username, 'password': password};
>           response = await httpClient
>               .post(credentials.ticketUrl, body: body)
>               .timeout(Duration(seconds: 25));
> @@ -50,13 +48,12 @@ Future<ProxmoxApiClient> authenticate(
>   
>       credentials = handleAccessTicketResponse(response, credentials);
>   
> -    return ProxmoxApiClient(
> -      credentials,
> -      httpClient: httpClient,
> -    );
> +    return ProxmoxApiClient(credentials, httpClient: httpClient);
>     } on TimeoutException catch (_) {
>       throw ProxmoxApiException(
> -        'Authentication takes unusually long, check network connection', 408);
> +      'Authentication takes unusually long, check network connection',
> +      408,
> +    );
>     } on NSErrorClientException catch (e) {
>       // Treat untrusted server certificate (-1202) as a handshake failure.
>       if (e.error.code == -1202) {
> diff --git a/pubspec.lock b/pubspec.lock
> index 66aa9b8..ffdf790 100644
> --- a/pubspec.lock
> +++ b/pubspec.lock
> @@ -375,7 +375,7 @@ packages:
>       source: hosted
>       version: "2.0.2"
>     objective_c:
> -    dependency: transitive
> +    dependency: "direct main"
>       description:
>         name: objective_c
>         sha256: "100a1c87616ab6ed41ec263b083c0ef3261ee6cd1dc3b0f35f8ddfa4f996fe52"
> diff --git a/pubspec.yaml b/pubspec.yaml
> index 9094c4d..a3426cc 100644
> --- a/pubspec.yaml
> +++ b/pubspec.yaml
> @@ -12,6 +12,7 @@ dependencies:
>     retry: ^3.1.0
>     cronet_http: ^1.5.0
>     cupertino_http: ^2.3.0
> +  objective_c: ^9.3.0
>   
>   dev_dependencies:
>     lints: ^6.0.0