From: Lukas Wagner <l.wagner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH widget-toolkit 0/2] notification: set 'Remove' button text to 'Reset to default' for built-ins
Date: Fri, 16 Feb 2024 11:15:04 +0100 [thread overview]
Message-ID: <fab42876-e53e-44b8-ae0e-090a7ae2a8a7@proxmox.com> (raw)
In-Reply-To: <c320f25b-ec97-4b1a-aba4-3a68e2edd046@proxmox.com>
ping - still applies on master. Retested it quickly, also seems to work fine.
On 1/8/24 11:43, Lukas Wagner wrote:
> ping
>
> On 12/14/23 10:48, Lukas Wagner wrote:
>> Deleting a built-in target/matcher does not remove it, but resets it
>> to its default settings. This was not really obvious from the UI.
>> This patch changes the 'Remove' button text based on the
>> selected target/matcher. If it is a built-in, the button text is
>> changed to 'Reset to default'. Also, if the built-in is not actually
>> modified, the button is disabled.
>>
>> Lukas Wagner (2):
>> remove button: allow to set custom confirmation message
>> notify: change 'Remove' button to 'Reset to default' for built-ins
>>
>> src/button/Button.js | 10 ++++-
>> src/panel/NotificationConfigView.js | 63 +++++++++++++++++++++++++++++
>> 2 files changed, 72 insertions(+), 1 deletion(-)
>>
>
--
- Lukas
next prev parent reply other threads:[~2024-02-16 10:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 9:48 Lukas Wagner
2023-12-14 9:48 ` [pve-devel] [PATCH widget-toolkit 1/2] remove button: allow to set custom confirmation message Lukas Wagner
2023-12-14 9:48 ` [pve-devel] [PATCH widget-toolkit 2/2] notify: change 'Remove' button to 'Reset to default' for built-ins Lukas Wagner
2024-01-08 10:43 ` [pve-devel] [PATCH widget-toolkit 0/2] notification: set 'Remove' button text " Lukas Wagner
2024-02-16 10:15 ` Lukas Wagner [this message]
2024-04-10 10:25 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fab42876-e53e-44b8-ae0e-090a7ae2a8a7@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox