From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, m.heiserer@proxmox.com
Subject: Re: [pve-devel] [PATCH manager 1/3] GUI: Allow passing the node to BackupConfig directly.
Date: Wed, 9 Mar 2022 13:28:24 +0100 [thread overview]
Message-ID: <fa86170c-c146-d66e-e5c5-9184c56c003f@proxmox.com> (raw)
In-Reply-To: <20220304115218.665615-1-m.heiserer@proxmox.com>
Am 04.03.22 um 12:52 schrieb Matthias Heiserer:
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
Some rationale for the change would be nice to have in the commit
message. Is there a scenario where me.pveSelNode is not the correct node?
> www/manager6/window/BackupConfig.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/window/BackupConfig.js b/www/manager6/window/BackupConfig.js
> index ca61b1e4..9609fe34 100644
> --- a/www/manager6/window/BackupConfig.js
> +++ b/www/manager6/window/BackupConfig.js
> @@ -24,7 +24,7 @@ Ext.define('PVE.window.BackupConfig', {
> throw "no volume specified";
> }
>
> - var nodename = me.pveSelNode.data.node;
> + var nodename = me.node ?? me.pveSelNode.data.node;
> if (!nodename) {
> throw "no node name specified";
> }
prev parent reply other threads:[~2022-03-09 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 11:52 Matthias Heiserer
2022-03-04 11:52 ` [pve-devel] [PATCH manager 2/3] GUI: Utils: Helpers for backup type and icon Matthias Heiserer
2022-03-09 12:32 ` Fabian Ebner
2022-03-04 11:52 ` [pve-devel] [PATCH manager 3/3] Storage GUI: Rewrite backup content view as TreePanel Matthias Heiserer
2022-03-09 12:39 ` Fabian Ebner
[not found] ` <9b872072-c6f0-3110-e532-b7225e8db2cb@proxmox.com>
2022-03-11 11:57 ` Fabian Ebner
2022-03-09 12:28 ` Fabian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa86170c-c146-d66e-e5c5-9184c56c003f@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox