From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH guest-common 2/2] ReplicationState: deterministically order replication jobs
Date: Fri, 27 May 2022 09:22:46 +0200 [thread overview]
Message-ID: <fa752164-396a-ac94-01ad-e808f24a1fe2@proxmox.com> (raw)
In-Reply-To: <65125da7-f122-9b18-5fc1-93cfccd79475@proxmox.com>
On 27/05/2022 08:23, Dominik Csapak wrote:
>>
>> nit, but couldn't this be
>>
>> return $joba->{guest} <=> $jobb->{guest} || $a cmp $b;
>>
>> instead, the right side of the logical OR only gets evaluated if the left side's
>> result is 0 (well also on undef and empty string "", but that cannot happen
>> with the spaceship operator).
>>
>
> yeah sure, i just blindly copied from the lines above. do we want
> to change that pattern for all of them? like this:
>
> ---
> return $sa->{last_iteration} <=> $sb->{last_iteration} ||
> $joba->{next_sync} <=> $jobb->{next_sync} ||
> $joba->{guest} <=> $jobb->{guest} ||
> $a cmp $b;
> ---
would be fine for me, but just for that we don't need a v2 and I'd rather like
some comment/review from Fabian (or anybody else that worked more closely with
replication) - I mean, on the other hand, this one could be applied
independently too...
next prev parent reply other threads:[~2022-05-27 7:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 11:41 [pve-devel] [RFC PATCH guest-common 1/2] ReplicationState: purge state from non local vms Dominik Csapak
2022-05-24 11:41 ` [pve-devel] [PATCH guest-common 2/2] ReplicationState: deterministically order replication jobs Dominik Csapak
2022-05-25 14:30 ` Thomas Lamprecht
2022-05-27 6:23 ` Dominik Csapak
2022-05-27 7:22 ` Thomas Lamprecht [this message]
2022-05-24 11:43 ` [pve-devel] [RFC PATCH guest-common 1/2] ReplicationState: purge state from non local vms Dominik Csapak
[not found] ` <1654180326.vcply64b2j.astroid@nora.none>
2022-06-03 6:45 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa752164-396a-ac94-01ad-e808f24a1fe2@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox