public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Alexander Zeidler <a.zeidler@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 5/9] report: move `lscpu` & cluster info to more appropriate sections
Date: Mon, 25 Mar 2024 09:11:35 +0100	[thread overview]
Message-ID: <fa3fded3-6404-42f7-a6cf-02dfcc023856@proxmox.com> (raw)
In-Reply-To: <20240322135933.164404-5-a.zeidler@proxmox.com>

And why are those more appropriate? Both fit's the general "always important"
section, so even though they fit the section you moved them too, they also
fit the general one, so some actual reasoning here would be good..

On 22/03/2024 14:59, Alexander Zeidler wrote:
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
>  PVE/Report.pm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/PVE/Report.pm b/PVE/Report.pm
> index 2c2a5e12..505629c7 100644
> --- a/PVE/Report.pm
> +++ b/PVE/Report.pm
> @@ -41,8 +41,6 @@ my $init_report_cmds = sub {
>  		'cat /etc/apt/sources.list',
>  		sub { dir2text('/etc/apt/sources.list.d/', '.+\.list') },
>  		sub { dir2text('/etc/apt/sources.list.d/', '.+\.sources') },
> -		'lscpu',
> -		'pvesh get /cluster/resources --type node --output-format=yaml',
>  	    ],
>  	},
>  	'system-load' => {
> @@ -96,6 +94,7 @@ my $init_report_cmds = sub {
>  	    order => 60,
>  	    cmds => [
>  		'pvecm nodes',
> +		'pvesh get /cluster/resources --type node --output-format=yaml',
>  		'pvecm status',
>  		'cat /etc/pve/corosync.conf 2>/dev/null',
>  		'ha-manager status',
> @@ -106,6 +105,7 @@ my $init_report_cmds = sub {
>  	    order => 70,
>  	    cmds => [
>  		'dmidecode -t bios',
> +		'lscpu',
>  		'lspci -nnk',
>  	    ],
>  	},





  reply	other threads:[~2024-03-25  8:11 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-22 13:59 [pve-devel] [PATCH manager 1/9] report: add kernel command line including boot time Alexander Zeidler
2024-03-22 13:59 ` [pve-devel] [PATCH manager 2/9] report: add `jobs.cfg` to debug related network/load/backup/etc issues Alexander Zeidler
2024-03-25  8:08   ` Thomas Lamprecht
2024-04-11 17:07     ` Alexander Zeidler
2024-03-22 13:59 ` [pve-devel] [PATCH manager 3/9] report: add list of upgradable packages Alexander Zeidler
2024-03-25  8:02   ` Thomas Lamprecht
2024-04-11 17:08     ` Alexander Zeidler
2024-03-22 13:59 ` [pve-devel] [PATCH manager 4/9] report: add `apt-cache policy` to list recognized APT sources Alexander Zeidler
2024-03-22 13:59 ` [pve-devel] [PATCH manager 5/9] report: move `lscpu` & cluster info to more appropriate sections Alexander Zeidler
2024-03-25  8:11   ` Thomas Lamprecht [this message]
2024-04-11 17:12     ` Alexander Zeidler
2024-03-22 13:59 ` [pve-devel] [PATCH manager 6/9] report: switch `dmidecode` to quiet to omit almost never needed info Alexander Zeidler
2024-03-25  8:20   ` Thomas Lamprecht
2024-04-11 17:13     ` Alexander Zeidler
2024-03-22 13:59 ` [pve-devel] [PATCH manager 7/9] report: add info of the mainboard in use Alexander Zeidler
2024-03-22 14:26   ` Aaron Lauterer
2024-04-11 17:14     ` Alexander Zeidler
2024-03-22 13:59 ` [pve-devel] [PATCH manager 8/9] report: add info about (un)used memory slots Alexander Zeidler
2024-03-22 18:05   ` Alexander Zeidler
2024-03-22 13:59 ` [pve-devel] [PATCH manager 9/9] report: add microcode info to better assess possible system impacts Alexander Zeidler
2024-03-22 16:44   ` Stoiko Ivanov
2024-03-22 18:54     ` Alexander Zeidler
2024-03-25  9:00   ` Thomas Lamprecht
2024-04-11 17:15     ` Alexander Zeidler
2024-03-25  7:52 ` [pve-devel] [PATCH manager 1/9] report: add kernel command line including boot time Thomas Lamprecht
2024-04-11 17:07   ` Alexander Zeidler
2024-04-11 17:20     ` Thomas Lamprecht
2024-04-18 15:57 ` Alexander Zeidler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa3fded3-6404-42f7-a6cf-02dfcc023856@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.zeidler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal