public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] ui: form/CalendarEvent: remove 'first saturday each month' example
@ 2021-11-11 12:09 Dominik Csapak
  2021-11-11 12:28 ` Thomas Lamprecht
  2021-11-11 20:07 ` Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Dominik Csapak @ 2021-11-11 12:09 UTC (permalink / raw)
  To: pve-devel

this is currently not supported by calendarevents in pve

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/form/CalendarEvent.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/www/manager6/form/CalendarEvent.js b/www/manager6/form/CalendarEvent.js
index 58090ddb..a15ec24f 100644
--- a/www/manager6/form/CalendarEvent.js
+++ b/www/manager6/form/CalendarEvent.js
@@ -28,7 +28,6 @@ Ext.define('PVE.form.CalendarEvent', {
 		    + Ext.String.format(gettext("Every {0} minutes"), 15),
 	    },
 	    { value: 'sun 01:00', text: gettext("Sunday") + " 01:00" },
-	    { value: 'sat *-1..7 15:00', text: gettext("First Saturday each month") + " 15:00" },
 	],
     },
 
-- 
2.30.2





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pve-devel] [PATCH manager] ui: form/CalendarEvent: remove 'first saturday each month' example
  2021-11-11 12:09 [pve-devel] [PATCH manager] ui: form/CalendarEvent: remove 'first saturday each month' example Dominik Csapak
@ 2021-11-11 12:28 ` Thomas Lamprecht
  2021-11-11 20:07 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2021-11-11 12:28 UTC (permalink / raw)
  To: Proxmox VE development discussion, Dominik Csapak

On 11.11.21 13:09, Dominik Csapak wrote:
> this is currently not supported by calendarevents in pve
> 

the obvious questions arises: why not support it instead? ^^

> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/form/CalendarEvent.js | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/www/manager6/form/CalendarEvent.js b/www/manager6/form/CalendarEvent.js
> index 58090ddb..a15ec24f 100644
> --- a/www/manager6/form/CalendarEvent.js
> +++ b/www/manager6/form/CalendarEvent.js
> @@ -28,7 +28,6 @@ Ext.define('PVE.form.CalendarEvent', {
>  		    + Ext.String.format(gettext("Every {0} minutes"), 15),
>  	    },
>  	    { value: 'sun 01:00', text: gettext("Sunday") + " 01:00" },
> -	    { value: 'sat *-1..7 15:00', text: gettext("First Saturday each month") + " 15:00" },
>  	],
>      },
>  
> 





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pve-devel] [PATCH manager] ui: form/CalendarEvent: remove 'first saturday each month' example
  2021-11-11 12:09 [pve-devel] [PATCH manager] ui: form/CalendarEvent: remove 'first saturday each month' example Dominik Csapak
  2021-11-11 12:28 ` Thomas Lamprecht
@ 2021-11-11 20:07 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2021-11-11 20:07 UTC (permalink / raw)
  To: Proxmox VE development discussion, Dominik Csapak

On 11.11.21 13:09, Dominik Csapak wrote:
> this is currently not supported by calendarevents in pve
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  www/manager6/form/CalendarEvent.js | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/www/manager6/form/CalendarEvent.js b/www/manager6/form/CalendarEvent.js
> index 58090ddb..a15ec24f 100644
> --- a/www/manager6/form/CalendarEvent.js
> +++ b/www/manager6/form/CalendarEvent.js
> @@ -28,7 +28,6 @@ Ext.define('PVE.form.CalendarEvent', {
>  		    + Ext.String.format(gettext("Every {0} minutes"), 15),
>  	    },
>  	    { value: 'sun 01:00', text: gettext("Sunday") + " 01:00" },
> -	    { value: 'sat *-1..7 15:00', text: gettext("First Saturday each month") + " 15:00" },
>  	],
>      },
>  
> 

replaced by a patch that comments this out for now, much thanks for catching!

https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=1c6433ea475518c993410fb2f0b1a48162bd0a3c;hp=ca67806281f4a750b2cd5c06a62847c526c8b972




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-11-11 20:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-11 12:09 [pve-devel] [PATCH manager] ui: form/CalendarEvent: remove 'first saturday each month' example Dominik Csapak
2021-11-11 12:28 ` Thomas Lamprecht
2021-11-11 20:07 ` Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal