From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer] fix space calculation for small disks for pve product
Date: Thu, 22 Jun 2023 16:29:18 +0200 [thread overview]
Message-ID: <f9cd19c3-aad0-2041-323f-1a223fcfa436@proxmox.com> (raw)
In-Reply-To: <20230622135713.1326873-1-s.ivanov@proxmox.com>
Am 22/06/2023 um 15:57 schrieb Stoiko Ivanov:
> The convoluted calculation logic in case the disks is 8GB leads to
> datasize becoming 16EiB further down:
> * after calculating and removing the rootsize from $rest, $rest becomes
> smaller than $space (which should be the minimal non-used space in the
> volume-group) - this leads to a negative value, which overflows in
> the `& ~0xFFF` opration.
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> tested in a VM with an 8GB disk
>
> Proxmox/Install.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-06-22 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 13:57 [pve-devel] " Stoiko Ivanov
2023-06-22 14:29 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9cd19c3-aad0-2041-323f-1a223fcfa436@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox