* [pve-devel] minor french translation correction
@ 2020-08-13 13:07 Luc Milland
2020-08-19 5:38 ` Thomas Lamprecht
0 siblings, 1 reply; 7+ messages in thread
From: Luc Milland @ 2020-08-13 13:07 UTC (permalink / raw)
To: pve-devel
Hello people,
first of all, as a quite new PVE user, I must thank all developers for
the awsome piece of code that PVE is.
I just noticed today that there are some mistakes in the french .po
files. I was about to submit a pull request, but I stumbled on the
"Contributor License Agreement" stuff and I don't think the minor
corrections I have to submit worth the hassle.
So here they are. To sum up :
- 'license' -> 'licence'
- 'Your subscription status is valid' -> "Votre licence est valide'
The latter is the most important, as the current translation says that
"the license has an invalid status" which is quite confusing :)
Here is a diff if this can help :
---------------------------------------------------
--- fr.po.orig 2020-08-13 14:53:19.702592758 +0200
+++ fr.po 2020-08-13 14:52:10.075303613 +0200
@@ -3125,7 +3125,7 @@
#: pve-manager/www/manager6/dc/Summary.js:269
msgid "Mixed Subscriptions"
-msgstr "Licenses mixtes"
+msgstr "Licences mixtes"
#: proxmox-widget-toolkit/node/NetworkEdit.js:173
#: proxmox-widget-toolkit/node/NetworkEdit.js:278
@@ -3454,7 +3454,7 @@
#: pve-manager/www/manager6/dc/Summary.js:262
msgid "No Subscription"
-msgstr "Sans license"
+msgstr "Sans licence"
#: pve-manager/www/manager6/form/VMSelector.js:161
msgid "No VM selected"
@@ -4402,7 +4402,7 @@
#: pve-manager/www/manager6/node/Subscription.js:178
#, fuzzy
msgid "Remove Subscription"
-msgstr "Sans license"
+msgstr "Supprimer la licence"
#: pmg-gui/js/Utils.js:647
msgid "Remove all attachments"
@@ -5372,13 +5372,13 @@
#: pmg-gui/js/ClusterAdministration.js:268
pmg-gui/js/NavigationTree.js:84
#: pmg-gui/js/Subscription.js:23
pve-manager/www/manager6/node/Config.js:395
msgid "Subscription"
-msgstr "License"
+msgstr "Licence"
#: pmg-gui/js/Subscription.js:15 pmg-gui/js/Subscription.js:124
#: pve-manager/www/manager6/node/Subscription.js:9
#: pve-manager/www/manager6/node/Subscription.js:124
msgid "Subscription Key"
-msgstr "Clé de license"
+msgstr "Clé de licence"
#: pve-manager/www/manager6/dc/Summary.js:56
msgid "Subscriptions"
@@ -6591,7 +6591,7 @@
#: pmg-gui/js/dashboard/SubscriptionInfo.js:21
#: pve-manager/www/manager6/dc/Summary.js:278
msgid "Your subscription status is valid."
-msgstr "Votre status de license n'est pas valide."
+msgstr "Votre licence est valide."
#: pve-manager/www/manager6/storage/ZFSPoolEdit.js:50
#: pve-manager/www/manager6/storage/ZFSPoolEdit.js:57
----------------------------------------------------------------------
cheers,
Luc
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [pve-devel] minor french translation correction
2020-08-13 13:07 [pve-devel] minor french translation correction Luc Milland
@ 2020-08-19 5:38 ` Thomas Lamprecht
2020-08-19 6:50 ` Alexandre DERUMIER
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Lamprecht @ 2020-08-19 5:38 UTC (permalink / raw)
To: Proxmox VE development discussion, Luc Milland
Hi!
On 13.08.20 15:07, Luc Milland wrote:
> first of all, as a quite new PVE user, I must thank all developers for the awsome piece of code that PVE is.
>
> I just noticed today that there are some mistakes in the french .po files. I was about to submit a pull request, but I stumbled on the "Contributor License Agreement" stuff and I don't think the minor corrections I have to submit worth the hassle.
>
Once done you can submit as many minor and major correction you want, we'd
appreciate that for sure. :)
But, I understand what you mean and I can pickup those few changes myself :)
> So here they are. To sum up :
>
> - 'license' -> 'licence'
> - 'Your subscription status is valid' -> "Votre licence est valide'
>
> The latter is the most important, as the current translation says that "the license has an invalid status" which is quite confusing :)
Thanks for this fixes, albeit I have one question:
Proxmox does not sells licenses, after all we're open source under AGPLv3, but
only (support) subscriptions, so is "licence" actually fitting for this?
My French is very limited, but checking with a translation tool[0] I get
"abonnement" or "souscription" as possible translations. Would one of them make
more sense in this context?
[0]: https://www.deepl.com/translator#en/fr/subscription
cheers,
Thomas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [pve-devel] minor french translation correction
2020-08-19 5:38 ` Thomas Lamprecht
@ 2020-08-19 6:50 ` Alexandre DERUMIER
2020-08-19 7:18 ` Luc Milland
0 siblings, 1 reply; 7+ messages in thread
From: Alexandre DERUMIER @ 2020-08-19 6:50 UTC (permalink / raw)
To: Proxmox VE development discussion
Hi Thomas,
>>My French is very limited, but checking with a translation tool[0] I get
>>"abonnement" or "souscription" as possible translations. Would one of them make
>>more sense in this context?
Hi, I think they are better indeed.
I don't have opinion about which one to choose, some company use "abonnement" term, or "souscription" term.
Maybe "souscription" is more used for a contract vs "abonnement" more used for a product
----- Mail original -----
De: "Thomas Lamprecht" <t.lamprecht@proxmox.com>
À: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>, "Luc Milland" <luc.milland@clementimprimeurs.fr>
Envoyé: Mercredi 19 Août 2020 07:38:15
Objet: Re: [pve-devel] minor french translation correction
Hi!
On 13.08.20 15:07, Luc Milland wrote:
> first of all, as a quite new PVE user, I must thank all developers for the awsome piece of code that PVE is.
>
> I just noticed today that there are some mistakes in the french .po files. I was about to submit a pull request, but I stumbled on the "Contributor License Agreement" stuff and I don't think the minor corrections I have to submit worth the hassle.
>
Once done you can submit as many minor and major correction you want, we'd
appreciate that for sure. :)
But, I understand what you mean and I can pickup those few changes myself :)
> So here they are. To sum up :
>
> - 'license' -> 'licence'
> - 'Your subscription status is valid' -> "Votre licence est valide'
>
> The latter is the most important, as the current translation says that "the license has an invalid status" which is quite confusing :)
Thanks for this fixes, albeit I have one question:
Proxmox does not sells licenses, after all we're open source under AGPLv3, but
only (support) subscriptions, so is "licence" actually fitting for this?
My French is very limited, but checking with a translation tool[0] I get
"abonnement" or "souscription" as possible translations. Would one of them make
more sense in this context?
[0]: https://www.deepl.com/translator#en/fr/subscription
cheers,
Thomas
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [pve-devel] minor french translation correction
2020-08-19 6:50 ` Alexandre DERUMIER
@ 2020-08-19 7:18 ` Luc Milland
2020-08-19 10:15 ` Thomas Lamprecht
0 siblings, 1 reply; 7+ messages in thread
From: Luc Milland @ 2020-08-19 7:18 UTC (permalink / raw)
To: Alexandre DERUMIER; +Cc: Proxmox VE development discussion
Hi,
I was about to second the choice of "souscription", but something does
not fit : in french, a subscription has no validity status per se.
Maybe "abonnement" would be better then, as it widely used for all kind
of services subscriptions (phone, dsl, ...).
cheers,
Luc
Le 19/08/2020 08:50, Alexandre DERUMIER a écrit :
> Hi Thomas,
>
>>> My French is very limited, but checking with a translation tool[0] I
>>> get
>>> "abonnement" or "souscription" as possible translations. Would one of
>>> them make
>>> more sense in this context?
>
> Hi, I think they are better indeed.
>
> I don't have opinion about which one to choose, some company use
> "abonnement" term, or "souscription" term.
>
> Maybe "souscription" is more used for a contract vs "abonnement" more
> used for a product
>
>
>
> ----- Mail original -----
> De: "Thomas Lamprecht" <t.lamprecht@proxmox.com>
> À: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
> "Luc Milland" <luc.milland@clementimprimeurs.fr>
> Envoyé: Mercredi 19 Août 2020 07:38:15
> Objet: Re: [pve-devel] minor french translation correction
>
> Hi!
>
> On 13.08.20 15:07, Luc Milland wrote:
>> first of all, as a quite new PVE user, I must thank all developers for
>> the awsome piece of code that PVE is.
>>
>> I just noticed today that there are some mistakes in the french .po
>> files. I was about to submit a pull request, but I stumbled on the
>> "Contributor License Agreement" stuff and I don't think the minor
>> corrections I have to submit worth the hassle.
>>
>
> Once done you can submit as many minor and major correction you want,
> we'd
> appreciate that for sure. :)
> But, I understand what you mean and I can pickup those few changes
> myself :)
>
>> So here they are. To sum up :
>>
>> - 'license' -> 'licence'
>> - 'Your subscription status is valid' -> "Votre licence est valide'
>>
>> The latter is the most important, as the current translation says that
>> "the license has an invalid status" which is quite confusing :)
>
> Thanks for this fixes, albeit I have one question:
> Proxmox does not sells licenses, after all we're open source under
> AGPLv3, but
> only (support) subscriptions, so is "licence" actually fitting for
> this?
>
> My French is very limited, but checking with a translation tool[0] I
> get
> "abonnement" or "souscription" as possible translations. Would one of
> them make
> more sense in this context?
>
> [0]: https://www.deepl.com/translator#en/fr/subscription
>
> cheers,
> Thomas
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [pve-devel] minor french translation correction
2020-08-19 7:18 ` Luc Milland
@ 2020-08-19 10:15 ` Thomas Lamprecht
2020-08-19 10:21 ` Luc Milland
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Lamprecht @ 2020-08-19 10:15 UTC (permalink / raw)
To: Proxmox VE development discussion, Luc Milland, Alexandre DERUMIER
Thanks to both of you, I now applied the following commit:
https://git.proxmox.com/?p=proxmox-i18n.git;a=commitdiff;h=e04cfca4e734234bddd56775c8e0519f4bb4a6bd
Please holler me if there's something wrong.
cheers,
Thomas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [pve-devel] minor french translation correction
2020-08-19 10:15 ` Thomas Lamprecht
@ 2020-08-19 10:21 ` Luc Milland
2020-08-19 10:42 ` Thomas Lamprecht
0 siblings, 1 reply; 7+ messages in thread
From: Luc Milland @ 2020-08-19 10:21 UTC (permalink / raw)
To: Thomas Lamprecht; +Cc: Proxmox VE development discussion, Alexandre DERUMIER
something is wrong :)
"Abonnement mixtes" > "Abonnements mixtes"
and "clé d'abonnement" does not sound great to me, but I do not have
better to suggest right now...
cheers,
Luc
Le 19/08/2020 12:15, Thomas Lamprecht a écrit :
> Thanks to both of you, I now applied the following commit:
> https://git.proxmox.com/?p=proxmox-i18n.git;a=commitdiff;h=e04cfca4e734234bddd56775c8e0519f4bb4a6bd
>
> Please holler me if there's something wrong.
>
> cheers,
> Thomas
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [pve-devel] minor french translation correction
2020-08-19 10:21 ` Luc Milland
@ 2020-08-19 10:42 ` Thomas Lamprecht
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Lamprecht @ 2020-08-19 10:42 UTC (permalink / raw)
To: Luc Milland; +Cc: Proxmox VE development discussion, Alexandre DERUMIER
On 19.08.20 12:21, Luc Milland wrote:
> something is wrong :)
>
> "Abonnement mixtes" > "Abonnements mixtes"
arg, pesky plural.. Fixed, thanks!
cheers,
Thomas
>
> and "clé d'abonnement" does not sound great to me, but I do not have better to suggest right now...
>
> cheers,
> Luc
>
> Le 19/08/2020 12:15, Thomas Lamprecht a écrit :
>> Thanks to both of you, I now applied the following commit:
>> https://git.proxmox.com/?p=proxmox-i18n.git;a=commitdiff;h=e04cfca4e734234bddd56775c8e0519f4bb4a6bd
>>
>> Please holler me if there's something wrong.
>>
>> cheers,
>> Thomas
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-08-19 10:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-13 13:07 [pve-devel] minor french translation correction Luc Milland
2020-08-19 5:38 ` Thomas Lamprecht
2020-08-19 6:50 ` Alexandre DERUMIER
2020-08-19 7:18 ` Luc Milland
2020-08-19 10:15 ` Thomas Lamprecht
2020-08-19 10:21 ` Luc Milland
2020-08-19 10:42 ` Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox