Re: [pve-devel] [PATCH v2 container 3/5] vmstatus: make template property optional

[Fabian Ebner <f.ebner@proxmox.com>]

Am 15.03.21 um 14:01 schrieb Thomas Lamprecht:
> On 11.03.21 11:26, Fabian Ebner wrote:
>> to avoid printing 'template: ' with 'pct status <id> --verbose' if it's false.
>>
>> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
>> ---
>>
>> Breaks pve-manager without the first patch! (e.g. guest's Start/Shutdown
>> buttons won't be updated anymore)
>>
> 
> same here, looks OK, but we can only apply it to master once we branched off
> the stable-6 release
> 

Ok, I'll try to remember and send a ping/rebased version then.

>> Changes from v1:
>>      * make property optional
>>
>>   src/PVE/LXC.pm | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
>> index bae236b..082cab8 100644
>> --- a/src/PVE/LXC.pm
>> +++ b/src/PVE/LXC.pm
>> @@ -235,7 +235,7 @@ sub vmstatus {
>>   	$d->{diskread} = 0;
>>   	$d->{diskwrite} = 0;
>>   
>> -	$d->{template} = PVE::LXC::Config->is_template($conf);
>> +	$d->{template} = 1 if PVE::LXC::Config->is_template($conf);
>>   	$d->{lock} = $conf->{lock} if $conf->{lock};
>>       }
>>   
>>
>