public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied:  [pve-network] d/postinst: do not break, if ipam-file moves fail
Date: Wed, 20 Nov 2024 16:25:46 +0100	[thread overview]
Message-ID: <f87c6ffb-0410-43b2-a6bd-988bff90b92c@proxmox.com> (raw)
In-Reply-To: <20241120141334.441585-1-s.ivanov@proxmox.com>

Am 20.11.24 um 15:13 schrieb Stoiko Ivanov:
> failing a package-install does not help repairing the situation - so
> inform the user about the issue instead of erroring out. The copy
> could fail if a node is not quorate, so writes in /etc/pve are a bit
> more likely to fail
> adapts the change introduced in
> d0628df ("debian: migrate legacy mac/ipam cache/state files")
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> noticed while looking at another small issue, and was reminded about the
> recent change for ifupdown2:
> https://lore.proxmox.com/pve-devel/20241113190113.678807-1-s.ivanov@proxmox.com/
> 
>  debian/libpve-network-perl.postinst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2024-11-20 15:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-20 14:13 [pve-devel] " Stoiko Ivanov
2024-11-20 15:25 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f87c6ffb-0410-43b2-a6bd-988bff90b92c@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal