public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: David Riley <d.riley@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: superseded: [PATCH manager/storage 0/2] fix #3936: add validation for ZFS blocksize
Date: Fri, 15 May 2026 10:00:14 +0200	[thread overview]
Message-ID: <f86a7a4a-9d39-45dd-8849-70216c403dc9@proxmox.com> (raw)
In-Reply-To: <20260512134852.142044-1-d.riley@proxmox.com>

superseded by:
https://lore.proxmox.com/pve-devel/20260515075159.45099-1-d.riley@proxmox.com/

On 5/12/26 3:48 PM, David Riley wrote:
> This patch series fixes #3936 [0] by implementing validation for the
> ZFS blocksize parameter in both the backend API and the frontend UI.
>
> Currently, providing an invalid blocksize (e.g., a non-power-of-two or
> a value outside the supported range) does not result in an immediate
> API error and therefore delays the failure to the volume creation.
> This patch series ensures that invalid configurations are caught
> early.
>
> Validation [1][2]:
> * Range: 512 bytes to 16 MiB.
> * Format: Allow positive integers with optional 'k' or 'm' suffix.
> * Constraint: Must be a power of two.
>
> [0] https://bugzilla.proxmox.com/show_bug.cgi?id=3936
> [1] https://openzfs.github.io/openzfs-docs/man/v2.4/7/zfsprops.7.html#volblocksize
> [2] https://openzfs.github.io/openzfs-docs/man/v2.4/7/zfsprops.7.html#recordsize
>
>
> pve-manager:
>
> David Riley (1):
>    fix #3936: ui: storage: add validation for ZFS blocksize
>
>   www/manager6/Utils.js               | 34 +++++++++++++++++++++++++++++
>   www/manager6/storage/ZFSEdit.js     |  1 +
>   www/manager6/storage/ZFSPoolEdit.js |  1 +
>   3 files changed, 36 insertions(+)
>
>
> pve-storage:
>
> David Riley (1):
>    fix #3936: api: add zfs-blocksize format
>
>   src/PVE/Storage/Plugin.pm        | 34 ++++++++++++++++++++++++++++++++
>   src/PVE/Storage/ZFSPoolPlugin.pm |  1 +
>   2 files changed, 35 insertions(+)
>
>
> Summary over all repositories:
>    5 files changed, 71 insertions(+), 0 deletions(-)
>




      parent reply	other threads:[~2026-05-15  8:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 13:48 [PATCH manager/storage 0/2] fix #3936: add validation for ZFS blocksize David Riley
2026-05-12 13:48 ` [PATCH pve-manager 1/2] fix #3936: ui: storage: " David Riley
2026-05-13 14:05   ` Fiona Ebner
2026-05-15  6:57     ` David Riley
2026-05-12 13:48 ` [PATCH pve-storage 2/2] fix #3936: api: add zfs-blocksize format David Riley
2026-05-13 14:35   ` applied: " Fiona Ebner
2026-05-15  8:00 ` David Riley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f86a7a4a-9d39-45dd-8849-70216c403dc9@proxmox.com \
    --to=d.riley@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal