public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH installer] fix #3057: remove ext3 option from installer
@ 2020-10-05 12:13 Oguz Bektas
  2020-10-22 17:00 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Oguz Bektas @ 2020-10-05 12:13 UTC (permalink / raw)
  To: pve-devel

we can safely remove this from the fs options

nobody uses this anymore, and it just ends up causing problems like in
[0]

[0]: https://forum.proxmox.com/threads/emlink-too-many-links.73108/

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 proxinstall | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/proxinstall b/proxinstall
index 4fb0748..8b0a2cb 100755
--- a/proxinstall
+++ b/proxinstall
@@ -279,7 +279,7 @@ my $config = {
 
 my $config_options = {};
 
-if ($cmdline =~ m/\s(ext3|ext4|xfs)(\s.*)?$/) {
+if ($cmdline =~ m/\s(ext4|xfs)(\s.*)?$/) {
     $config_options->{filesys} = $1;
 } else {
     $config_options->{filesys} = 'ext4';
@@ -774,12 +774,6 @@ sub update_progress {
 }
 
 my $fssetup = {
-    ext3 => {
-	mkfs => 'mkfs.ext3 -F',
-	mkfs_root_opt => '',
-	mkfs_data_opt => '-m 0',
-	root_mountopt => 'errors=remount-ro',
-    },
     ext4 => {
 	mkfs => 'mkfs.ext4 -F',
 	mkfs_root_opt => '',
@@ -2982,7 +2976,7 @@ sub create_hdoption_view {
 
     my $fstypecb = Gtk3::ComboBoxText->new();
 
-    my $fstype = ['ext3', 'ext4', 'xfs',
+    my $fstype = ['ext4', 'xfs',
 		  'zfs (RAID0)', 'zfs (RAID1)',
 		  'zfs (RAID10)', 'zfs (RAIDZ-1)',
 		  'zfs (RAIDZ-2)', 'zfs (RAIDZ-3)'];
-- 
2.20.1




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-22 17:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-05 12:13 [pve-devel] [PATCH installer] fix #3057: remove ext3 option from installer Oguz Bektas
2020-10-22 17:00 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal