From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server 2/2] fix #4620: cfg2cmd: drive device: correctly handle IDE for q35
Date: Thu, 20 Jul 2023 16:53:11 +0200 [thread overview]
Message-ID: <f80fddc7-1647-db08-1542-d406ae0da465@proxmox.com> (raw)
In-Reply-To: <20230720094502.4146921-2-f.ebner@proxmox.com>
On 20/07/2023 11:45, Fiona Ebner wrote:
> Only unit 0 for IDE is supported with machine type q35. Currently,
> QEMU will fail startup with machine type q35 with an error like
>> Can't create IDE unit 1, bus supports only 1 units
> when ide1 or ide3 is configured.
>
> Make sure to keep backwards compat form migration by leaving ide0 and
> ide2 fixed. Since starting with ide1 or ide3 never worked, they can be
> moved to a controller with a higher ID without issue.
>
> Reported in the community forum:
> https://forum.proxmox.com/threads/124615/post-543127
> https://forum.proxmox.com/threads/130815/
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> For PVE 9, we could simplify the mapping to N -> controller=N,unit=0
> while version guarding with running QEMU machine version. Might be
> slightly nicer, but it'd add an extra conditional, so probably not
> worth it.
>
> PVE/QemuServer.pm | 11 +++++++++++
> test/cfg2cmd/q35-ide.conf.cmd | 4 ++--
> 2 files changed, 13 insertions(+), 2 deletions(-)
>
>
applied, thanks!
next prev parent reply other threads:[~2023-07-20 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 9:45 [pve-devel] [PATCH qemu-server 1/2] test: add tests with multiple IDE CD-ROM drives Fiona Ebner
2023-07-20 9:45 ` [pve-devel] [PATCH qemu-server 2/2] fix #4620: cfg2cmd: drive device: correctly handle IDE for q35 Fiona Ebner
2023-07-20 14:53 ` Thomas Lamprecht [this message]
2023-07-20 14:52 ` [pve-devel] applied: [PATCH qemu-server 1/2] test: add tests with multiple IDE CD-ROM drives Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f80fddc7-1647-db08-1542-d406ae0da465@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox