[pve-devel] [PATCH qemu-server] cfg2cmd: also set smm=off for "none" type display

[pve-devel] [PATCH qemu-server] cfg2cmd: also set smm=off for "none" type display

[Oguz Bektas]

issue reported in community forum [0]

like "serial[n]" display we also need to set this option for
"none", otherwise we get a boot loop like in [1].

[0]: https://forum.proxmox.com/threads/debian-vms-wont-start-anymore.99508
[1]: https://forum.proxmox.com/threads/pve-7-0-all-vms-with-cloud-init-seabios-fail-during-boot-process-bootloop-disk-not-found.97310/post-427129

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 PVE/QemuServer.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 9b76512..94576e1 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3410,7 +3410,7 @@ my sub should_disable_smm {
     my ($conf, $vga) = @_;
 
     return (!defined($conf->{bios}) || $conf->{bios} eq 'seabios') &&
-	$vga->{type} && $vga->{type} =~ m/^serial\d+$/;
+	$vga->{type} && $vga->{type} =~ m/^(serial\d+|none)$/;
 }
 
 sub config_to_command {
-- 
2.30.2

Re: [pve-devel] [PATCH qemu-server] cfg2cmd: also set smm=off for "none" type display

[Fabian Ebner]

Am 11.11.21 um 13:05 schrieb Oguz Bektas:
> issue reported in community forum [0]
> 
> like "serial[n]" display we also need to set this option for
> "none", otherwise we get a boot loop like in [1].
> 
> [0]: https://forum.proxmox.com/threads/debian-vms-wont-start-anymore.99508
> [1]: https://forum.proxmox.com/threads/pve-7-0-all-vms-with-cloud-init-seabios-fail-during-boot-process-bootloop-disk-not-found.97310/post-427129
> 

Tested for my reproducer and indeed, with display none and without this 
patch, there is a boot loop.

Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
Tested-by: Fabian Ebner <f.ebner@proxmox.com>

> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>   PVE/QemuServer.pm | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 9b76512..94576e1 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -3410,7 +3410,7 @@ my sub should_disable_smm {
>       my ($conf, $vga) = @_;
>   
>       return (!defined($conf->{bios}) || $conf->{bios} eq 'seabios') &&
> -	$vga->{type} && $vga->{type} =~ m/^serial\d+$/;
> +	$vga->{type} && $vga->{type} =~ m/^(serial\d+|none)$/;
>   }
>   
>   sub config_to_command {
>