From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Oguz Bektas <o.bektas@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] cfg2cmd: also set smm=off for "none" type display
Date: Thu, 11 Nov 2021 14:04:42 +0100 [thread overview]
Message-ID: <f7ac1fb7-a463-af20-c268-2fa76949f198@proxmox.com> (raw)
In-Reply-To: <20211111120558.1013617-1-o.bektas@proxmox.com>
Am 11.11.21 um 13:05 schrieb Oguz Bektas:
> issue reported in community forum [0]
>
> like "serial[n]" display we also need to set this option for
> "none", otherwise we get a boot loop like in [1].
>
> [0]: https://forum.proxmox.com/threads/debian-vms-wont-start-anymore.99508
> [1]: https://forum.proxmox.com/threads/pve-7-0-all-vms-with-cloud-init-seabios-fail-during-boot-process-bootloop-disk-not-found.97310/post-427129
>
Tested for my reproducer and indeed, with display none and without this
patch, there is a boot loop.
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
Tested-by: Fabian Ebner <f.ebner@proxmox.com>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> PVE/QemuServer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 9b76512..94576e1 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -3410,7 +3410,7 @@ my sub should_disable_smm {
> my ($conf, $vga) = @_;
>
> return (!defined($conf->{bios}) || $conf->{bios} eq 'seabios') &&
> - $vga->{type} && $vga->{type} =~ m/^serial\d+$/;
> + $vga->{type} && $vga->{type} =~ m/^(serial\d+|none)$/;
> }
>
> sub config_to_command {
>
prev parent reply other threads:[~2021-11-11 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 12:05 Oguz Bektas
2021-11-11 13:04 ` Fabian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ac1fb7-a463-af20-c268-2fa76949f198@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox