From: Fiona Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] fix #4549: capture and bubble up qemu errors correctly
Date: Tue, 13 Jun 2023 09:05:58 +0200 [thread overview]
Message-ID: <f716eaf5-1fc3-0912-a5cb-3a627ae5c3c0@proxmox.com> (raw)
In-Reply-To: <bd26e8d0-9586-34d4-4c62-fbc6cbc29a09@proxmox.com>
Am 12.06.23 um 16:54 schrieb Thomas Lamprecht:
> Am 12/06/2023 um 13:22 schrieb Fiona Ebner:
>> Instead of getting rid of the "print once per line" handling, can't we
>> rather adapt the invocation for backup to bubble up the other log lines too?
>
> would it make sense to differ between stderr/stdour and do log_warn and print,
> respectively?
>
Could also be done, but from a quick look in the code, QEMU also prints
its info_report() to stderr. Could lead to a bit of over-reporting as
warnings in our task logs, but might be fine for most cases; there's not
too many info_report instances.
>>
>> Always prefixing the messages with "QEMU: " seems fine to me (even
>> things like the "bridge 'vmbr1' does not exist" message technically come
>> from the pve-bridge script, it's still part of the QEMU invocation ;)).
>
> not sure if we really need a prefix at all here..
Well, the migration code currently expects it and it helps to recognize
where the message comes from in complex logs like migration (and after
this bug is fixed, backup).
prev parent reply other threads:[~2023-06-13 7:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 8:46 Christoph Heiss
2023-06-12 11:22 ` Fiona Ebner
2023-06-12 11:26 ` Fiona Ebner
2023-06-12 14:54 ` Thomas Lamprecht
2023-06-13 7:05 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f716eaf5-1fc3-0912-a5cb-3a627ae5c3c0@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox