From: Lukas Wagner <l.wagner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] superseded: [PATCH manager/proxmox-mail-forward 0/2] install proxmox-mail-forward at /usr/libexec
Date: Wed, 16 Jul 2025 09:41:17 +0200 [thread overview]
Message-ID: <f6dc861c-2a1b-433c-8ce8-e5029c3726a2@proxmox.com> (raw)
In-Reply-To: <1035168769.2761.1751885108695@webmail.proxmox.com>
On 2025-07-07 12:45, Fabian Grünbichler wrote:
> Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
>
> although the comment in the postinst (that got moved over)
> could be shortened to just say that the entry is unconditionally
> rewritten, IMHO ;)
>
Thanks for the review :) I shortened the comment a bit for v2 and added your R-b tags.
https://lore.proxmox.com/pve-devel/20250716073759.40752-1-l.wagner@proxmox.com/T/#t
--
- Lukas
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-16 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 12:20 [pve-devel] " Lukas Wagner
2025-06-25 12:20 ` [pve-devel] [PATCH manager 1/1] d/postinst: remove old pvemailforward migration logic Lukas Wagner
2025-06-25 12:20 ` [pve-devel] [PATCH proxmox-mail-forward 1/1] install to /usr/libexec instead of /usr/bin Lukas Wagner
2025-07-07 10:45 ` [pve-devel] [PATCH manager/proxmox-mail-forward 0/2] install proxmox-mail-forward at /usr/libexec Fabian Grünbichler
2025-07-16 7:41 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6dc861c-2a1b-433c-8ce8-e5029c3726a2@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox