From: Fiona Ebner <f.ebner@proxmox.com>
To: Robert Obkircher <r.obkircher@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v4 pve-container 2/5] Propagate prestart-hook warnings to task-log.
Date: Mon, 17 Nov 2025 16:32:54 +0100 [thread overview]
Message-ID: <f5ef093b-bfa4-4084-8dd2-10d1e4559334@proxmox.com> (raw)
In-Reply-To: <7d7cabf4-616a-4217-ba7d-3c2c6ba5f948@proxmox.com>
Am 17.11.25 um 12:31 PM schrieb Robert Obkircher:
>
> On 11/13/25 17:35, Fiona Ebner wrote:
>> Am 13.11.25 um 4:04 PM schrieb Robert Obkircher:
>>> diff --git a/src/lxc-pve-prestart-hook b/src/lxc-pve-prestart-hook
>>> index 73125e1..f5dd728 100755
>>> --- a/src/lxc-pve-prestart-hook
>>> +++ b/src/lxc-pve-prestart-hook
>>> @@ -28,17 +28,6 @@ eval {
>>> $have_sdn = 1;
>>> };
>>> -my $WARNFD;
>>> -
>>> -sub log_warn {
>>> - my ($vmid, $message) = @_;
>>> -
>>> - if (!defined($WARNFD)) {
>>> - open($WARNFD, '>', "/run/pve/ct-${vmid}.warnings");
>>> - }
>>> - print $WARNFD "$message\n";
>>> -}
>>> -
>>> PVE::LXC::Tools::lxc_hook(
>>> 'pre-start',
>>> 'lxc',
>>> @@ -53,6 +42,15 @@ PVE::LXC::Tools::lxc_hook(
>>> PVE::RESTEnvironment->setup_default_cli_env();
>>> + my $warn_file = "/run/pve/ct-${vmid}.warnings";
>>> + # open eagerly so logging works inside the protected_call
>>> chroot
>> Nit: Maybe "early" instead of "eagerly"?
> I was specifically thinking about eager/lazy evaluation.
Personally, I wouldn't call having code inside a CODE ref/sub variable
"lazily evaluated". The code hasn't been called yet, not just not
evaluated. Or do you mean something else?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-11-17 15:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 15:02 [pve-devel] [PATCH v4 pve-container 0/5] warn that nesting may be required Robert Obkircher
2025-11-13 15:02 ` [pve-devel] [PATCH v4 pve-container 1/5] Ensure that container startup warnings are displayed if startup fails Robert Obkircher
2025-11-13 16:14 ` Fiona Ebner
2025-11-17 11:30 ` Robert Obkircher
2025-11-17 15:15 ` Fiona Ebner
2025-11-13 15:03 ` [pve-devel] [PATCH v4 pve-container 2/5] Propagate prestart-hook warnings to task-log Robert Obkircher
2025-11-13 16:36 ` Fiona Ebner
2025-11-17 11:31 ` Robert Obkircher
2025-11-17 15:32 ` Fiona Ebner [this message]
2025-11-13 15:03 ` [pve-devel] [PATCH v4 pve-container 3/5] fix #6897: warn that nesting may be required for systemd Robert Obkircher
2025-11-13 15:03 ` [pve-devel] [PATCH v4 pve-container 4/5] fix #6897: constrain and untaint path for systemd version detection Robert Obkircher
2025-11-13 15:03 ` [pve-devel] [PATCH v4 pve-container 4/5] fix #6897: constrain and untaint path when detecting systemd version Robert Obkircher
2025-11-13 15:03 ` [pve-devel] [PATCH v4 pve-container 5/5] fix #6897: also warn in the post_clone and post_create hooks Robert Obkircher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5ef093b-bfa4-4084-8dd2-10d1e4559334@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=r.obkircher@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox