[pve-devel] [PATCH manager] pvereport: get pressure stall information

[pve-devel] [PATCH manager] pvereport: get pressure stall information

[Oguz Bektas]

PSI can be queried in /proc/pressure/{cpu,io,memory} for the
corresponding resources. this helps us track down disruptions caused
by resource overcommitment.

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 PVE/Report.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/PVE/Report.pm b/PVE/Report.pm
index fc54e9e2..e89edbb0 100644
--- a/PVE/Report.pm
+++ b/PVE/Report.pm
@@ -24,6 +24,7 @@ my $init_report_cmds = sub {
 		sub { dir2text('/etc/apt/sources.list.d/', '.*list') },
 		sub { dir2text('/etc/apt/sources.list.d/', '.*sources') },
 		'lscpu',
+		'head /proc/pressure/*',
 		'pvesh get /cluster/resources --type node --output-format=yaml',
 	    ],
 	},
-- 
2.20.1

[pve-devel] applied: [PATCH manager] pvereport: get pressure stall information

[Thomas Lamprecht]

On 11.05.21 13:04, Oguz Bektas wrote:
> PSI can be queried in /proc/pressure/{cpu,io,memory} for the
> corresponding resources. this helps us track down disruptions caused
> by resource overcommitment.
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>  PVE/Report.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks! But the inserted order felt a bit weird to me, I found it
fitting better below the `top` command a few commands above, but looking at
the whole report module I found that it was due for some refactoring anyway,
so as follow-up I:

* got rid of all those ugly side-effects we relied on
* made the definition hash the single source of info, dropping the extra
  order array, which was always a bit weird
* split out the top and PSI into a new "system-load" section
* adding some stderr output about what's going on in dir2text

if something is off with my followups just shout.