[pve-devel] applied: [PATCH installer] proxmox-chroot: replace nix::(u)mount calls with external (u)mount

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 11.03.25 um 14:27 schrieb Christoph Heiss:
> Comes with a reduction of 52 -> 40 in terms of crate dependencies for
> proxmox-chroot, 198 -> 192 for a full workspace build.
> 
> Currently, this is done inconsistently anyway, i.e. there are calls to
> the external mount(8) as well as mount(2) and umount(2) via `nix`.
> Just switch over to calling the external programs completely, which in
> turn allows to drop the `nix` crate dependency from the tree.
> 
> No functional changes.
> 
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>  debian/control             |  1 -
>  proxmox-chroot/Cargo.toml  |  1 -
>  proxmox-chroot/src/main.rs | 81 +++++++++++++++++++++++++-------------
>  3 files changed, 53 insertions(+), 30 deletions(-)
> 
>

applied, thanks!

btw. to throw in a crate I'd not be sad to see get removed: clap, at least
if upstream still is full in the refactoring for the sake of it and adding
yet another way to do things...


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel