From: Lukas Wagner <l.wagner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH many v7 00/19] notifications: notification metadata matching improvements
Date: Thu, 4 Jul 2024 15:32:26 +0200 [thread overview]
Message-ID: <f54a3f82-cb94-407e-962b-671b7c9497f6@proxmox.com> (raw)
In-Reply-To: <172009776514.180658.14915076870639634148@yuna.proxmox.com>
On 2024-07-04 14:56, Fabian Grünbichler wrote:
> Quoting Lukas Wagner (2024-06-10 10:40:19)
>> This patch series attempts to improve the user experience when creating
>> notification matchers.
>>
>> Some of the noteworthy changes:
>> - Fixup inconsistent 'hostname' field. Some notification events sent
>> the hostname including a domain, while other did not.
>> This series unifies the behavior, now the field only includes the hostname
>> without a domain. Also updated the docs to reflect this change.
>> - Allow setting a custom backup job ID, similar how we handle it for
>> sync/prune jobs in PBS (to allow recognizable names used in matchers)
>> - Adding columns for backup job ID/replication job ID in the UI
>> - New metadata fields:
>> - job-id: Job ID for backup-jobs or replication-jobs
>> - Add an API that enumerates known notification metadata fields/values
>> - Suggest known fields/values in match rule window
>> - Some code clean up for match rule edit window
>> - Extended the 'exact' match-field mode - it now allows setting multiple
>> allowed values, separated via ',':
>> e.g. `match-field exact:type=replication,fencing
>> Originally, I created a separate 'list' match type for this, but
>> since the semantics for a list with one value and 'exact' mode
>> are identical, I decided to just extend 'exact'.
>> This is a safe change since there are are no values where a ','
>> makes any sense (config IDs, hostnames)
>>
>> NOTE: Might need a versionened break, since the widget-toolkit-patches
>> depend on new APIs provided by pve-manager. If the API is not present,
>> creating matchers with 'match-field' does not work (cannot load lists
>> of known values/fields)
>>
>> Inter-Dependencies:
>> - the widget-toolkit dep in pve-manager needs to be bumped
>> to at least 4.1.4
>> (we need "utils: add mechanism to add and override translatable notification event
>> descriptions in the product specific UIs", otherwise the UI breaks
>> with the pve-manager patches applied) --> already included a patch for
>> this
>> - widget-toolkit relies on a new API endpoint provided by pve-manager:
>> --> we require a versioned break in widget-toolkit on pve-manager
>
> pve-guest-common is also needed by pve-manager AFAICT?
Oh yes, of course. Always a bit hard to keep track of everything in
large patch series' like this one ;)
> and manual invocations of backup jobs are broken in a cluster if the target
> node is not yet upgraded, since that would set the still unknown job-id
> parameter.. combined with the "job-id value can't be trusted" aspect, it might
> be better to skip setting it for manual invocations?
Short summary of our off-list discussion:
We agreed to make 'job-id' usable by root only to prevent abuse (e.g.
setting it to the job-id of other backup jobs, or some random value)
and to stop setting for manually triggered backup jobs.
That slightly worsens UX when e.g. triggering a backup job
to test matcher settings. To mitigate that, a follow up
could change the 'Run Backup Job' in such a way that it does not do a
direct vzdump API call, but requests execution of the backup job in the
near future from pvescheduler - similar how the 'Run now' button
for storage replication works.
Thanks a lot for the feedback!
--
- Lukas
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-07-04 13:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 8:40 Lukas Wagner
2024-06-10 8:40 ` [pve-devel] [PATCH pve-guest-common v7 01/19] vzdump: common: allow 'job-id' as a parameter without being in schema Lukas Wagner
2024-06-10 8:40 ` [pve-devel] [PATCH manager v7 02/19] api: jobs: vzdump: pass job 'job-id' parameter Lukas Wagner
2024-07-04 12:53 ` Fabian Grünbichler
2024-06-10 8:40 ` [pve-devel] [PATCH manager v7 03/19] ui: dc: backup: send 'job-id' property when starting a backup job manually Lukas Wagner
2024-06-10 8:40 ` [pve-devel] [PATCH manager v7 04/19] ui: dc: backup: allow to set custom job id in advanced settings Lukas Wagner
2024-06-10 8:40 ` [pve-devel] [PATCH manager v7 05/19] api: replication: add 'job-id' to notification metadata Lukas Wagner
2024-07-04 13:08 ` [pve-devel] applied: " Fabian Grünbichler
2024-06-10 8:40 ` [pve-devel] [PATCH manager v7 06/19] vzdump: apt: notification: do not include domain in 'hostname' field Lukas Wagner
2024-07-04 13:08 ` [pve-devel] applied: " Fabian Grünbichler
2024-06-10 8:40 ` [pve-devel] [PATCH manager v7 07/19] api: replication: include 'hostname' field for notifications Lukas Wagner
2024-07-04 13:08 ` [pve-devel] applied: " Fabian Grünbichler
2024-06-10 8:40 ` [pve-devel] [PATCH manager v7 08/19] api: notification: add API for getting known metadata fields/values Lukas Wagner
2024-06-10 8:40 ` [pve-devel] [PATCH manager v7 09/19] ui: utils: add overrides for translatable notification fields/values Lukas Wagner
2024-06-10 8:40 ` [pve-devel] [PATCH manager v7 10/19] d/control: bump proxmox-widget-toolkit dependency to 4.1.4 Lukas Wagner
2024-06-10 8:40 ` [pve-devel] [PATCH widget-toolkit v7 11/19] notification: matcher: match-field: show known fields/values Lukas Wagner
2024-06-10 8:40 ` [pve-devel] [PATCH widget-toolkit v7 12/19] notification: matcher: move match-field formulas to local viewModel Lukas Wagner
2024-06-10 8:40 ` [pve-devel] [PATCH widget-toolkit v7 13/19] notification: matcher: move match-calendar fields to panel Lukas Wagner
2024-06-10 8:40 ` [pve-devel] [PATCH widget-toolkit v7 14/19] notification: matcher: move match-severity " Lukas Wagner
2024-06-10 8:40 ` [pve-devel] [PATCH docs v7 15/19] notification: clarify that 'hostname' does not include the domain Lukas Wagner
2024-07-04 13:12 ` [pve-devel] applied: " Fabian Grünbichler
2024-06-10 8:40 ` [pve-devel] [PATCH docs v7 16/19] notifications: describe new notification metadata fields Lukas Wagner
2024-06-10 8:40 ` [pve-devel] [PATCH docs v7 17/19] notifications: match-field 'exact'-mode can now match multiple values Lukas Wagner
2024-06-10 8:40 ` [pve-devel] [PATCH docs v7 18/19] notifications: fix typo in 'notification' Lukas Wagner
2024-07-04 13:12 ` [pve-devel] applied: " Fabian Grünbichler
2024-06-10 8:40 ` [pve-devel] [PATCH docs v7 19/19] notifications: backport some rephrased parts from PBS docs Lukas Wagner
2024-07-04 13:13 ` [pve-devel] applied: " Fabian Grünbichler
2024-07-04 12:56 ` [pve-devel] [PATCH many v7 00/19] notifications: notification metadata matching improvements Fabian Grünbichler
2024-07-04 13:32 ` Lukas Wagner [this message]
2024-07-05 13:59 ` [pve-devel] superseded: " Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f54a3f82-cb94-407e-962b-671b7c9497f6@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox