public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-network 09/13] sdn: generate route map / prefix list configuration on sdn apply
Date: Fri, 27 Mar 2026 11:47:40 +0100	[thread overview]
Message-ID: <f52ae9f5-feec-4c60-a2ad-e5cdc2e4d9f0@proxmox.com> (raw)
In-Reply-To: <20260325094142.174364-24-s.hanreich@proxmox.com>

`has_pending_changes` should also include checks for route-maps or
prefix-lists

On 2026-03-25 10:44, Stefan Hanreich wrote:
> Commit the newly introduced configuration files to the running
> configuration when applying the SDN configuration, so the FRR config
> generation logic can use them to generate the FRR configuration for
> them.
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
>  src/PVE/Network/SDN.pm | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm
> index 0bb36bf..93b6698 100644
> --- a/src/PVE/Network/SDN.pm
> +++ b/src/PVE/Network/SDN.pm
> @@ -25,6 +25,8 @@ use PVE::Network::SDN::Subnets;
>  use PVE::Network::SDN::Dhcp;
>  use PVE::Network::SDN::Frr;
>  use PVE::Network::SDN::Fabrics;
> +use PVE::Network::SDN::RouteMaps;
> +use PVE::Network::SDN::PrefixLists;
>  
>  my $RUNNING_CFG_FILENAME = "sdn/.running-config";
>  
> @@ -207,12 +209,16 @@ sub compile_running_cfg {
>      my $controllers_cfg = PVE::Network::SDN::Controllers::config();
>      my $subnets_cfg = PVE::Network::SDN::Subnets::config();
>      my $fabrics_cfg = PVE::Network::SDN::Fabrics::config();
> +    my $route_maps_cfg = PVE::Network::SDN::RouteMaps::config();
> +    my $prefix_lists_cfg = PVE::Network::SDN::PrefixLists::config();
>  
>      my $vnets = { ids => $vnets_cfg->{ids} };
>      my $zones = { ids => $zones_cfg->{ids} };
>      my $controllers = { ids => $controllers_cfg->{ids} };
>      my $subnets = { ids => $subnets_cfg->{ids} };
>      my $fabrics = { ids => $fabrics_cfg->to_sections() };
> +    my $route_maps = { ids => $route_maps_cfg->to_sections() };
> +    my $prefix_lists = { ids => $prefix_lists_cfg->to_sections() };
>  
>      $cfg = {
>          version => $version,
> @@ -221,6 +227,8 @@ sub compile_running_cfg {
>          controllers => $controllers,
>          subnets => $subnets,
>          fabrics => $fabrics,
> +        'route-maps' => $route_maps,
> +        'prefix-lists' => $prefix_lists,
>      };
>  
>      return $cfg;
> @@ -425,9 +433,11 @@ configuration.
>  =cut
>  
>  sub generate_frr_raw_config {
> -    my ($running_config, $fabric_config) = @_;
> +    my ($running_config, $fabric_config, $route_map_config, $prefix_list_config) = @_;
>  
>      $running_config = PVE::Network::SDN::running_config() if !$running_config;
> +    $prefix_list_config = PVE::Network::SDN::PrefixLists::config(1) if !$prefix_list_config;
> +    $route_map_config = PVE::Network::SDN::RouteMaps::config(1) if !$route_map_config;
>      $fabric_config = PVE::Network::SDN::Fabrics::config(1) if !$fabric_config;
>  
>      my $frr_config = {};
> @@ -438,7 +448,7 @@ sub generate_frr_raw_config {
>      my $nodename = PVE::INotify::nodename();
>  
>      return PVE::RS::SDN::get_frr_raw_config(
> -        $frr_config->{'frr'}, $fabric_config, $nodename,
> +        $frr_config->{'frr'}, $prefix_list_config, $route_map_config, $fabric_config, $nodename,
>      );
>  }
>  





  reply	other threads:[~2026-03-27 10:47 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25  9:41 [PATCH cluster/network/proxmox{-ve-rs,-perl-rs} 00/27] Add support for route maps / prefix lists to SDN Stefan Hanreich
2026-03-25  9:41 ` [PATCH pve-cluster 1/2] cfs: add 'sdn/route-maps.cfg' to observed files Stefan Hanreich
2026-03-25  9:41 ` [PATCH pve-cluster 2/2] cfs: add 'sdn/prefix-lists.cfg' " Stefan Hanreich
2026-03-25  9:41 ` [PATCH proxmox-ve-rs 1/9] sdn-types: add common route-map helper types Stefan Hanreich
2026-03-25  9:41 ` [PATCH proxmox-ve-rs 2/9] frr: implement routemap match/set statements via adjacent tagging Stefan Hanreich
2026-03-26 14:44   ` Hannes Laimer
2026-03-27  9:02     ` Stefan Hanreich
2026-03-25  9:41 ` [PATCH proxmox-ve-rs 3/9] frr: allow rendering prefix-lists/route-maps separately Stefan Hanreich
2026-03-25 14:32   ` Gabriel Goller
2026-03-26 12:17     ` Stefan Hanreich
2026-03-27 10:50   ` Hannes Laimer
2026-03-27 11:34     ` Stefan Hanreich
2026-03-25  9:41 ` [PATCH proxmox-ve-rs 4/9] frr-templates: change route maps template to adapt to new types Stefan Hanreich
2026-03-25 14:33   ` Gabriel Goller
2026-03-25 14:58     ` Gabriel Goller
2026-03-27 11:01   ` Hannes Laimer
2026-03-27 11:17     ` Stefan Hanreich
2026-03-25  9:41 ` [PATCH proxmox-ve-rs 5/9] ve-config: add prefix list section config Stefan Hanreich
2026-03-25  9:41 ` [PATCH proxmox-ve-rs 6/9] ve-config: frr: implement frr config generation for prefix lists Stefan Hanreich
2026-03-25  9:41 ` [PATCH proxmox-ve-rs 7/9] ve-config: add route map section config Stefan Hanreich
2026-03-25 14:35   ` Gabriel Goller
2026-03-26 13:49     ` Stefan Hanreich
2026-03-25  9:41 ` [PATCH proxmox-ve-rs 8/9] ve-config: frr: implement frr config generation for route maps Stefan Hanreich
2026-03-25 15:03   ` Gabriel Goller
2026-03-26 13:50     ` Stefan Hanreich
2026-03-27 11:17   ` Hannes Laimer
2026-03-27 11:21     ` Stefan Hanreich
2026-03-25  9:41 ` [PATCH proxmox-ve-rs 9/9] ve-config: fabrics: adapt frr config generation to new format Stefan Hanreich
2026-03-25  9:41 ` [PATCH proxmox-perl-rs 1/3] pve-rs: sdn: add route maps module Stefan Hanreich
2026-03-26 10:32   ` Wolfgang Bumiller
2026-03-26 13:57     ` Stefan Hanreich
2026-03-25  9:41 ` [PATCH proxmox-perl-rs 2/3] pve-rs: sdn: add prefix lists module Stefan Hanreich
2026-03-25  9:41 ` [PATCH proxmox-perl-rs 3/3] sdn: add prefix list / route maps to frr config generation helper Stefan Hanreich
2026-03-25  9:41 ` [PATCH pve-network 01/13] controller: bgp: evpn: adapt to new match / set frr config syntax Stefan Hanreich
2026-03-26 15:19   ` Hannes Laimer
2026-03-27 10:05     ` Stefan Hanreich
2026-03-25  9:41 ` [PATCH pve-network 02/13] sdn: add prefix lists module Stefan Hanreich
2026-03-25  9:41 ` [PATCH pve-network 03/13] api2: add prefix list module Stefan Hanreich
2026-03-26 15:01   ` Hannes Laimer
2026-03-27  9:57     ` Stefan Hanreich
2026-03-25  9:41 ` [PATCH pve-network 04/13] sdn: add route map module Stefan Hanreich
2026-03-25  9:41 ` [PATCH pve-network 05/13] api2: add route maps api module Stefan Hanreich
2026-03-26 15:05   ` Hannes Laimer
2026-03-27  9:57     ` Stefan Hanreich
2026-03-25  9:41 ` [PATCH pve-network 06/13] api2: add route map module Stefan Hanreich
2026-03-26 15:07   ` Hannes Laimer
2026-03-27  9:57     ` Stefan Hanreich
2026-03-25  9:41 ` [PATCH pve-network 07/13] api2: add route map entry module Stefan Hanreich
2026-03-26 15:13   ` Hannes Laimer
2026-03-27 10:01     ` Stefan Hanreich
2026-03-25  9:41 ` [PATCH pve-network 08/13] evpn controller: add route_map_{in,out} parameter Stefan Hanreich
2026-03-27 10:44   ` Hannes Laimer
2026-03-27 11:12     ` Stefan Hanreich
2026-03-25  9:41 ` [PATCH pve-network 09/13] sdn: generate route map / prefix list configuration on sdn apply Stefan Hanreich
2026-03-27 10:47   ` Hannes Laimer [this message]
2026-03-27 11:13     ` Stefan Hanreich
2026-03-25  9:41 ` [PATCH pve-network 10/13] tests: add simple route map test case Stefan Hanreich
2026-03-25  9:41 ` [PATCH pve-network 11/13] tests: add bgp evpn route map/prefix list testcase Stefan Hanreich
2026-03-25  9:41 ` [PATCH pve-network 12/13] tests: add route map with prefix " Stefan Hanreich
2026-03-25  9:41 ` [PATCH pve-network 13/13] bgp controller: allow configuring custom route maps Stefan Hanreich
2026-03-25 11:38 ` [PATCH cluster/network/proxmox{-ve-rs,-perl-rs} 00/27] Add support for route maps / prefix lists to SDN Stefan Hanreich
2026-03-27 10:17 ` Stefan Hanreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f52ae9f5-feec-4c60-a2ad-e5cdc2e4d9f0@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.hanreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal