[pve-devel] [PATCH manager v2] ui: node: use plug icon for node shutdown

[pve-devel] [PATCH manager v2] ui: node: use plug icon for node shutdown

[Aaron Lauterer]

this makes it optically different to the guest shutdown and hopefully
helps to avoid confusion and accidential node shutdowns.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---

Notes:
    changes since:
    v1:
    * rebased with updated indentations
    
    This came up in the forum and I do like the idea and the change is small
    enough to just quickly do it
    https://forum.proxmox.com/threads/disable-server-shutdown-restart-from-the-web-interface.12602/page-2#post-769235

 www/manager6/node/Config.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js
index 4cd1671c..8946a616 100644
--- a/www/manager6/node/Config.js
+++ b/www/manager6/node/Config.js
@@ -117,7 +117,7 @@ Ext.define('PVE.node.Config', {
             handler: function () {
                 node_command('shutdown');
             },
-            iconCls: 'fa fa-power-off',
+            iconCls: 'fa fa-plug',
         });
 
         var shellBtn = Ext.create('PVE.button.ConsoleButton', {
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager v2] ui: node: use plug icon for node shutdown

[Dominik Csapak]

I don't think we'll prevent all users from mis-clicking the button with this change,
but having a different Icon can probably avoid *some* confusion.

I don't really like that this icon would imply we 'pull the plug',
but there is sadly not really a better icon that is different from
the shutdown one.

I'm a bit unsure myself, but *if* we want to have a different icon here than for
the guest shutdown, consider this patch:

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

On 7/2/25 11:52, Aaron Lauterer wrote:
> this makes it optically different to the guest shutdown and hopefully
> helps to avoid confusion and accidential node shutdowns.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> 
> Notes:
>      changes since:
>      v1:
>      * rebased with updated indentations
>      
>      This came up in the forum and I do like the idea and the change is small
>      enough to just quickly do it
>      https://forum.proxmox.com/threads/disable-server-shutdown-restart-from-the-web-interface.12602/page-2#post-769235
> 
>   www/manager6/node/Config.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js
> index 4cd1671c..8946a616 100644
> --- a/www/manager6/node/Config.js
> +++ b/www/manager6/node/Config.js
> @@ -117,7 +117,7 @@ Ext.define('PVE.node.Config', {
>               handler: function () {
>                   node_command('shutdown');
>               },
> -            iconCls: 'fa fa-power-off',
> +            iconCls: 'fa fa-plug',
>           });
>   
>           var shellBtn = Ext.create('PVE.button.ConsoleButton', {



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager v2] ui: node: use plug icon for node shutdown

[Thomas Lamprecht]

Am 14.07.25 um 12:48 schrieb Dominik Csapak:
> I don't think we'll prevent all users from mis-clicking the button with this change,
> but having a different Icon can probably avoid *some* confusion.
> 
> I don't really like that this icon would imply we 'pull the plug',
> but there is sadly not really a better icon that is different from
> the shutdown one.
> 
> I'm a bit unsure myself, but *if* we want to have a different icon here than for
> the guest shutdown, consider this patch:

Checking this out I'm also not sure about this.

IMO it might be a better option to have different confirmation
prompts, where the one for the node has some more info, like the
amount of running guests that might be affected, or a hint that the
cluster might loose quorum if that nodes is shutdown, like if in a
three node cluster one node is already unavailable and then the user
continues to shutdown another one - can be fine, but would not hurt
to get some extra hint about implications.

Yet another thing might be offering to optionally give a shutdown
reason, i.e. some predefined (appllying updates, maintenance) and
a free form one. A bit like what windows server does, and while I
normally really do not want to take that as prime example for good
UX, it might have some value for orgs with multiple admins to see
the original reason behind a shutdown or reboot.

Maybe there is more, but that's implementation details, having
any of that info there would make the dialogue much more visual
distinct and informational compared to a slightly different button
icon, especially for users with (slightly) impaired visual senses.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel