[pve-devel] [PATCH widget-toolkit 1/2] data/*Store: drop storeid requirement

[pve-devel] [PATCH widget-toolkit 1/2] data/*Store: drop storeid requirement

[Dominik Csapak]

We never use that and it serves no purpose. It probably was meant
to be the upstream config 'storeId' which would add the store to
the Ext.StoreManager. This is unpractical though, since then the
store has to be explicitely destroyed, otherwise the StoreManager
retains a reference and the GC cannot remove the store.

Since donwstream users of the store can simply give the 'storeId'
property anyway if they need to be managed by the StoreManager,
drop the requirement here.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
i tried to measure the memory impact of the StoreManager, but i did not
find an easy way to deterministically find out. On average though,
using 'storeId' everywhere, we retained a bit more memory (single
digit percentage difference) as far as i could see.

but since we never actually use that functionality, i'd opt for
not doing it by default and if we need it for a single store,
do it manually (and then make sure the store gets removed again)

if we apply this, i can prepare patch series to remove the
'storeid's from pve/pmg/pbs

 src/data/ObjectStore.js | 4 ----
 src/data/RRDStore.js    | 5 -----
 src/data/UpdateStore.js | 3 ---
 3 files changed, 12 deletions(-)

diff --git a/src/data/ObjectStore.js b/src/data/ObjectStore.js
index 860cbfd..cb41f9c 100644
--- a/src/data/ObjectStore.js
+++ b/src/data/ObjectStore.js
@@ -21,10 +21,6 @@ Ext.define('Proxmox.data.ObjectStore', {
 
         config = config || {};
 
-	if (!config.storeid) {
-	    config.storeid = 'proxmox-store-' + ++Ext.idSeed;
-	}
-
         Ext.applyIf(config, {
 	    model: 'KeyValue',
             proxy: {
diff --git a/src/data/RRDStore.js b/src/data/RRDStore.js
index 67ffb57..7c96ded 100644
--- a/src/data/RRDStore.js
+++ b/src/data/RRDStore.js
@@ -37,11 +37,6 @@ Ext.define('Proxmox.data.RRDStore', {
 	    config.interval = 30000;
 	}
 
-	// set a new storeid
-	if (!config.storeid) {
-	    config.storeid = 'rrdstore-' + ++Ext.idSeed;
-	}
-
 	// rrdurl is required
 	if (!config.rrdurl) {
 	    throw "no rrdurl specified";
diff --git a/src/data/UpdateStore.js b/src/data/UpdateStore.js
index be85e4f..cd51089 100644
--- a/src/data/UpdateStore.js
+++ b/src/data/UpdateStore.js
@@ -33,9 +33,6 @@ Ext.define('Proxmox.data.UpdateStore', {
 	    delete config.interval;
 	}
 
-	if (!config.storeid) {
-	    throw "no storeid specified";
-	}
 
 	let load_task = new Ext.util.DelayedTask();
 
-- 
2.20.1

[pve-devel] [PATCH widget-toolkit 2/2] node/ServiceView: remove storeid

[Dominik Csapak]

it's not needed anymore

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/node/ServiceView.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/node/ServiceView.js b/src/node/ServiceView.js
index 351ab09..93ffcb1 100644
--- a/src/node/ServiceView.js
+++ b/src/node/ServiceView.js
@@ -22,7 +22,6 @@ Ext.define('Proxmox.node.ServiceView', {
 
 	let rstore = Ext.create('Proxmox.data.UpdateStore', {
 	    interval: 1000,
-	    storeid: 'proxmox-services' + me.nodename,
 	    model: 'proxmox-services',
 	    proxy: {
                 type: 'proxmox',
-- 
2.20.1

[pve-devel] applied: [PATCH widget-toolkit 1/2] data/*Store: drop storeid requirement

[Thomas Lamprecht]

On 11.03.21 10:14, Dominik Csapak wrote:
> We never use that and it serves no purpose. It probably was meant
> to be the upstream config 'storeId' which would add the store to
> the Ext.StoreManager. This is unpractical though, since then the
> store has to be explicitely destroyed, otherwise the StoreManager
> retains a reference and the GC cannot remove the store.
> 
> Since donwstream users of the store can simply give the 'storeId'
> property anyway if they need to be managed by the StoreManager,
> drop the requirement here.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> i tried to measure the memory impact of the StoreManager, but i did not
> find an easy way to deterministically find out. On average though,
> using 'storeId' everywhere, we retained a bit more memory (single
> digit percentage difference) as far as i could see.
> 
> but since we never actually use that functionality, i'd opt for
> not doing it by default and if we need it for a single store,
> do it manually (and then make sure the store gets removed again)
> 
> if we apply this, i can prepare patch series to remove the
> 'storeid's from pve/pmg/pbs
> 
>  src/data/ObjectStore.js | 4 ----
>  src/data/RRDStore.js    | 5 -----
>  src/data/UpdateStore.js | 3 ---
>  3 files changed, 12 deletions(-)
> 
>

applied, thanks!

[pve-devel] applied: [PATCH widget-toolkit 2/2] node/ServiceView: remove storeid

[Thomas Lamprecht]

On 11.03.21 10:14, Dominik Csapak wrote:
> it's not needed anymore
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/node/ServiceView.js | 1 -
>  1 file changed, 1 deletion(-)
> 
>

applied, thanks!