From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>,
Leo Nunner <l.nunner@proxmox.com>
Subject: Re: [pve-devel] [PATCH container] fix #4192: add new architecture-dependent path to check for newer versions of systemd
Date: Mon, 12 Sep 2022 11:30:09 +0200 [thread overview]
Message-ID: <f47adeec-0214-43b6-a50c-6366abbf97aa@proxmox.com> (raw)
In-Reply-To: <e806e2a2-b720-3ed0-6327-b80bd213a35a@proxmox.com>
[snip]
>>
>> # non systemd based containers work with pure cgroupv2
>> sub unified_cgroupv2_support {
>> - my ($self) = @_;
>> + my ($self, $conf) = @_;
>
> why pass the whole config if you just need the arch? Please avoid overly generic
> parameter in signatures if only one specific thing is required.
>
AFAICS, not even that is necessary, since a 'LXC::Setup' object has the config in self
so we could do there a '$self->{confg}->{arch}' and omit the parameter passing completely
(or am i missing something else here?)
next prev parent reply other threads:[~2022-09-12 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 11:45 Leo Nunner
2022-09-12 9:13 ` Thomas Lamprecht
2022-09-12 9:30 ` Dominik Csapak [this message]
2022-09-12 9:30 ` Dominik Csapak
2022-09-12 9:43 ` Thomas Lamprecht
2022-09-12 9:37 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f47adeec-0214-43b6-a50c-6366abbf97aa@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=l.nunner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox