public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Bruce Wainer <brwainer@gmail.com>
Subject: Re: [pve-devel] [pve-manager] Adding real disk usage information (discussion)
Date: Mon, 19 Apr 2021 08:55:00 +0200	[thread overview]
Message-ID: <f436fcc6-11cf-201d-9ad0-8148dda6d15b@proxmox.com> (raw)
In-Reply-To: <CAPEXuizzBG7CKtzVHYO068MPB4A-mriypQSNgJYYcwbwrF5_gA@mail.gmail.com>

On 4/16/21 22:18, Bruce Wainer wrote:
> Hello,
> 

Hi,

> I am interested in seeing real disk usage information for VM Disks and CT
> Volumes, on storage types that have thin provisioning and/or snapshots.
> Specifically I would like to see "Current Disk Usage (Thin)" and either
> "Snapshot Usage" or "Total Disk Usage". I only use local ZFS on servers at
> this time, but I'm sure the GUI side would be best made flexible.

while this sounds sensible, this will get hard very fast.
For example, take a LVM-Thin storage.

I have a template which has an LV which uses some space.
This can have X linked clones, where each clone can have Y snapshots.

since lvmthin lvs/snapshots/etc. are only very loosely coupled.
It is very hard to attribute the correct number to any
of those vms/templates. (e.g. do you want to calculate the
template storage again for each vm? only once? what if
you cloned a vm from a snapshot?)

It gets even harder on storage that can deduplicate (e.g. ZFS) or
where the 'real' usage is dynamically inflated by some form of replica 
(e.g. Ceph).

So, while this sounds nice, and we would probably not oppose a clean
solution, this is not a trivial problem to solve.

> 
> Is someone interested in helping with this? Where would I start, especially
> on the GUI part, if I were to develop this myself?

anyway, to answer this question, the storage plugins in the backend can
be found in the pve-storage git repo[0]

the point where the status api calls of the vms/cts are called live
in qemu-server[1] and pve-container[2] respectively
(the api part is in PVE/API2/)

you can find the gui part in pve-manger[3] in www/manager6

also if you want to send patches, please read the developer 
documentation [4] especially the bit about the CLA

if you have any more question, please ask :)

hope this helps
kind regards

0: 
https://git.proxmox.com/?p=pve-storage.git;a=tree;f=PVE/Storage;h=fd53af5e74407deda65785b164fb61a4f644a6e0;hb=refs/heads/master
1: https://git.proxmox.com/?p=qemu-server.git;a=summary
2: https://git.proxmox.com/?p=pve-container.git;a=summary
3: 
https://git.proxmox.com/?p=pve-manager.git;a=tree;f=www/manager6;hb=refs/heads/master
4: https://pve.proxmox.com/wiki/Developer_Documentation

> 
> Thank you,
> Bruce Wainer
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 





  reply	other threads:[~2021-04-19  6:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16 20:18 Bruce Wainer
2021-04-19  6:55 ` Dominik Csapak [this message]
2021-04-21  1:37   ` Bruce Wainer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f436fcc6-11cf-201d-9ad0-8148dda6d15b@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=brwainer@gmail.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal