public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: Re: [PATCH v2 qemu-server] tests: allow running migration tests in parallel
Date: Fri, 18 Dec 2020 17:50:32 +0100	[thread overview]
Message-ID: <f3e72927-5115-796e-25db-fd74ad6e63c5@proxmox.com> (raw)
In-Reply-To: <20201217093702.15182-1-f.ebner@proxmox.com>

On 17/12/2020 10:37, Fabian Ebner wrote:
> It's not easily possible to use separate JSON files for the test configuration,
> because part of it is generated with perl code. While this could be encoded too,
> it seems cleaner to use the "run a single test by specifing the name"
> functionality while adding a way for make to obtain a list of the test names.
> 
> Each test has (and needs) its own directory now, meaning the log files do not
> need to be renamed anymore.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> Changes from v1:
>     * add definedness check before comparing $single_test_name
> 
>  test/Makefile                  |  9 +++--
>  test/run_qemu_migrate_tests.pl | 62 ++++++++++++++++++++--------------
>  2 files changed, 44 insertions(+), 27 deletions(-)
> 
>

On my dev VM with 16 cores I now need 4.6s instead of 36s thanks to this, that's
acceptable again.

applied, thanks!




      reply	other threads:[~2020-12-18 16:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17  9:37 [pve-devel] " Fabian Ebner
2020-12-18 16:50 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3e72927-5115-796e-25db-fd74ad6e63c5@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal