public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Fabian Ebner <f.ebner@proxmox.com>,
	pve-devel@lists.proxmox.com, m.heiserer@proxmox.com
Subject: Re: [pve-devel] [PATCH manager] storage GUI: fix unintuitive sorting order
Date: Mon, 21 Feb 2022 09:39:45 +0100	[thread overview]
Message-ID: <f3c0f818-d8df-0de0-6068-57e00b30c23c@proxmox.com> (raw)
In-Reply-To: <7c867147-33b0-427c-4c6f-09fa84562d7f@proxmox.com>

On 21.02.22 09:32, Fabian Ebner wrote:
> Am 18.02.22 um 11:42 schrieb Matthias Heiserer:
>> The backups in the 'Backups' table in Storages are now initially
>> sorted by column 'Name' ascending.
>>
>> Previously, they were first sorted by 'vmid' descending, then by date
>> descending. This was unintuitive as 'vmid' doesn't exist as column
>> in the GUI, and only 'Date' displayed a sorting arrow.
>>
>> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
>> ---
>>  www/manager6/storage/BackupView.js | 6 +-----
>>  1 file changed, 1 insertion(+), 5 deletions(-)
>>
> Please note that the order was recently intentionally changed to be like
> that, see commit 58f4e6ac387561a16ec370812083d60a12dc4cfe
> 
> That said, you do have a point. One way to improve the situation might
> be to add a vmid column, but we could also think about using a tree view
> for backups instead.
>> @Thomas: Would the latter be okay for you?

A tree view like PBS has would be nice in general IMO for the storage
backup content view, as with lots of VMs that's way easier to browse/work
with than the flat list. IIRC we talked about that already in the past,
in the context of the prune group button, but it wasn't to pressing then
and went off the radar.

Adding the vmid, at least as by-default hidden column, would be the easiest
(quickest) change now though, but this is IMO not to pressing that we need
to do any stop-gap measures.




      reply	other threads:[~2022-02-21  8:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18 10:42 Matthias Heiserer
2022-02-21  8:32 ` Fabian Ebner
2022-02-21  8:39   ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3c0f818-d8df-0de0-6068-57e00b30c23c@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=m.heiserer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal