From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH storage 2/2] prune backups: make vmid filtering more robust
Date: Fri, 9 Apr 2021 12:51:56 +0200 [thread overview]
Message-ID: <f3818c10-6e99-3520-d9ec-16c7c154f416@proxmox.com> (raw)
In-Reply-To: <20210407102537.28046-2-f.ebner@proxmox.com>
On 07.04.21 12:25, Fabian Ebner wrote:
> by relying on archive_info's vmid first. archive_info is already used to
> determine if it's a standard name, and in that case the vmid is certainly set.
>
> Also add asserts to make sure we got what we expected.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> continuing from previous patch:
> ...but it really seems that something went wrong with the vmids for the listing,
> and making it more robust shouldn't hurt.
>
> PVE/Storage/Plugin.pm | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>
applied, small followup for VMID casing and including the info about which
values failed in the message, thanks!
next prev parent reply other threads:[~2021-04-09 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 10:25 [pve-devel] [PATCH storage 1/2] plugin: subdir files: backup: don't match for vmid against the full path Fabian Ebner
2021-04-07 10:25 ` [pve-devel] [PATCH storage 2/2] prune backups: make vmid filtering more robust Fabian Ebner
2021-04-09 10:51 ` Thomas Lamprecht [this message]
2021-04-09 6:59 ` [pve-devel] [PATCH storage 1/2] plugin: subdir files: backup: don't match for vmid against the full path Fabian Ebner
2021-04-09 10:51 ` [pve-devel] applied: " Thomas Lamprecht
2021-04-09 12:52 ` Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3818c10-6e99-3520-d9ec-16c7c154f416@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox