From: Matthias Heiserer <m.heiserer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH v2 http-server 2/2] AnyEvent: Fix #3990 - make small files uploadable
Date: Tue, 12 Jul 2022 13:32:11 +0200 [thread overview]
Message-ID: <f37dd708-fae5-28fd-a08d-27b4b16bf8fa@proxmox.com> (raw)
In-Reply-To: <f309d69c-584a-4f7e-8fc7-017547a0938e@proxmox.com>
On 06.07.2022 18:09, Daniel Tschlatscher wrote:
> All errors above return HTTP status 501 ("Not implemented") which I
> think is rather confusing, even if they include a descriptive error
> message.
> I'd wager that it would be better to differentiate between malformed
> multi-form data and internal server errors, and return 400 for incorrect
> user inputs. This makes it much easier for anyone (that is not a
> browser) to interface with this part of the API.
>
> I am not quite sure how much precedence fixing the errors above should
> have, as even most API users will probably never encounter them.
> However, I feel like that at the very least the basic error message
> should be revised to no longer return 501 and to include a more
> descriptive error message than just "upload failed".
As we talked off list: The 501 error is what we currently return. I
don't mind using more descriptive ones, but as it changes the API I'm
not sure if this patch is the right place.
Thanks for testing!
next prev parent reply other threads:[~2022-07-12 11:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 13:48 [pve-devel] [PATCH v2 http-server 1/2] AnyEvent: whitespace fix Matthias Heiserer
2022-05-13 13:49 ` [pve-devel] [PATCH v2 http-server 2/2] AnyEvent: Fix #3990 - make small files uploadable Matthias Heiserer
2022-07-06 16:09 ` Daniel Tschlatscher
2022-07-12 11:32 ` Matthias Heiserer [this message]
2022-09-29 15:13 ` [pve-devel] applied: " Thomas Lamprecht
2022-09-29 15:06 ` [pve-devel] applied: [PATCH v2 http-server 1/2] AnyEvent: whitespace fix Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f37dd708-fae5-28fd-a08d-27b4b16bf8fa@proxmox.com \
--to=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox