From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Matthias Heiserer <m.heiserer@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 qemu-server] api: ignore --efitype parameter when creating efidisk for ARM VM
Date: Thu, 23 Feb 2023 16:33:52 +0100 [thread overview]
Message-ID: <f362aae2-e4c3-d977-fd53-e0637e477878@proxmox.com> (raw)
In-Reply-To: <20230130125751.170088-1-m.heiserer@proxmox.com>
Am 30/01/2023 um 13:57 schrieb Matthias Heiserer:
> Required because there's one single efi for ARM, and
> the 2m/4m difference doesn't seem to apply.
>
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
>
> Changes from v1:
> Rather than change the efi type in the GUI, ignore it
> in the API
>
> PVE/QemuServer.pm | 2 +-
> PVE/QemuServer/Drive.pm | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
>
applied, thanks!
But subject slightly reworded as it wasn't really in the api-specific part and
having the efitype parameter include some CLI option hyphen included is not
really useful when reading the git log. Also moved the description up to the
actual efitype format string schema, fits better there as in the whole efidisk
one - especially as this is only relevant for an unofficial niche architecture.
prev parent reply other threads:[~2023-02-23 15:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 12:57 [pve-devel] " Matthias Heiserer
2023-02-23 15:33 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f362aae2-e4c3-d977-fd53-e0637e477878@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox