From: Christoph Heiss <c.heiss@proxmox.com>
To: Filip Schauer <f.schauer@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer 1/1] fix #4869: Show state in management interface ComboBox
Date: Tue, 10 Oct 2023 13:33:45 +0200 [thread overview]
Message-ID: <f33tfdti2sgqzfe2tfoq5pnu7ut5rqybvyk2yaun7cmjc3qjpu@g65liga3lt4p> (raw)
In-Reply-To: <20230804102646.34999-2-f.schauer@proxmox.com>
Needs to be done for the TUI installer as well. Easiest way here is to
add `state` to each interface in Proxmox::Sys::RunEnv::query_netdevs(),
then deserialize that in `setup::Interface`.
Looking at it, adding the MAC address there too would be great, if you
are already at it.
On Fri, Aug 04, 2023 at 12:26:46PM +0200, Filip Schauer wrote:
>
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
> ---
> proxinstall | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/proxinstall b/proxinstall
> index d5b2565..9316578 100755
> --- a/proxinstall
> +++ b/proxinstall
> @@ -347,7 +347,7 @@ sub create_ipconf_view {
>
> my $get_device_desc = sub {
> my $iface = shift;
> - return "$iface->{name} - $iface->{mac} ($iface->{driver})";
> + return "$iface->{name} - $iface->{mac} ($iface->{driver}) - $iface->{state}";
I think it would be better to only show the state if the interface is
actually UP - thus drawing immediate attention to these list entries and
not completely overloading that dropdown.
Maybe even append it as "(UP)" instead of by dash (as it does not really
identify the interface, but rather is a property of it).
> };
>
> my $run_env = Proxmox::Install::RunEnv::get();
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
next prev parent reply other threads:[~2023-10-10 11:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 10:26 [pve-devel] [PATCH installer 0/1] " Filip Schauer
2023-08-04 10:26 ` [pve-devel] [PATCH installer 1/1] " Filip Schauer
2023-10-10 11:33 ` Christoph Heiss [this message]
2023-10-10 11:55 ` Thomas Lamprecht
2023-10-10 12:56 ` Christoph Heiss
2023-10-10 13:13 ` Thomas Lamprecht
2023-10-11 9:54 ` Filip Schauer
2023-10-11 10:58 ` Thomas Lamprecht
2023-10-11 15:20 ` Filip Schauer
2023-10-12 13:04 ` Filip Schauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f33tfdti2sgqzfe2tfoq5pnu7ut5rqybvyk2yaun7cmjc3qjpu@g65liga3lt4p \
--to=c.heiss@proxmox.com \
--cc=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox