From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 manager 2/2] ui: vm selector: don't add invalid not found items
Date: Mon, 25 Sep 2023 13:18:19 +0200 [thread overview]
Message-ID: <f2c84bab-f833-4d58-8bdd-ab79009ddf66@proxmox.com> (raw)
In-Reply-To: <20230707080230.11949-2-f.ebner@proxmox.com>
On 7/7/23 10:02, Fiona Ebner wrote:
> Doing a simple numericity check and warn in the console so developers
> can notice if there is something off.
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> New in v2.
>
> www/manager6/form/VMSelector.js | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js
> index bf2c8df7..4b04ac30 100644
> --- a/www/manager6/form/VMSelector.js
> +++ b/www/manager6/form/VMSelector.js
> @@ -136,7 +136,11 @@ Ext.define('PVE.form.VMSelector', {
> let selection = value.map(item => {
> let found = store.findRecord('vmid', item, 0, false, true, true);
> if (!found) {
> - notFound.push(item);
> + if (Ext.isNumeric(item)) {
> + notFound.push(item);
> + } else {
> + console.warn(`invalid item in vm selection: ${item}`);
> + }
> }
> return found;
> }).filter(r => r);
LGTM
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
next prev parent reply other threads:[~2023-09-25 11:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 8:02 [pve-devel] [PATCH v2 stable-7+master manager 1/2] ui: vm selector: handle empty string gracefully Fiona Ebner
2023-07-07 8:02 ` [pve-devel] [PATCH v2 manager 2/2] ui: vm selector: don't add invalid not found items Fiona Ebner
2023-09-25 11:18 ` Dominik Csapak [this message]
2023-08-30 9:15 ` [pve-devel] [PATCH v2 stable-7+master manager 1/2] ui: vm selector: handle empty string gracefully Fiona Ebner
2023-09-25 10:59 ` Fiona Ebner
2023-09-25 11:17 ` Dominik Csapak
2023-09-25 11:36 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2c84bab-f833-4d58-8bdd-ab79009ddf66@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox