From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 container] vm status: force int where appropriate
Date: Thu, 17 Jun 2021 14:49:35 +0200 [thread overview]
Message-ID: <f2b744e1-3b71-efda-e418-74251fa83e44@proxmox.com> (raw)
In-Reply-To: <20210601064306.13507-1-f.ebner@proxmox.com>
On 01.06.21 08:43, Fabian Ebner wrote:
> In the case of a running container with cgroupv2, swap would be a string,
> causing a
> size.toFixed is not a function
> error for the format_size call in the containers's "Summary" page in the UI.
>
> The vmids from config_list() are already integers as the return schema expects,
> while the opt_vmid passed from the status/current API call needs to be
> converted.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> Changes from v1:
> * also make vmid an integer.
>
> src/PVE/LXC.pm | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2021-06-17 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 6:43 [pve-devel] " Fabian Ebner
2021-06-01 6:43 ` [pve-devel] [PATCH v2 qemu-server] " Fabian Ebner
2021-06-17 12:49 ` [pve-devel] applied: " Thomas Lamprecht
2021-06-17 12:49 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2b744e1-3b71-efda-e418-74251fa83e44@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox